Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 2.10 version of #5190 GPIO code #5197

Merged
merged 2 commits into from
Jun 19, 2024
Merged

chore: 2.10 version of #5190 GPIO code #5197

merged 2 commits into from
Jun 19, 2024

Conversation

pfeerick
Copy link
Member

Summary of changes:

@pfeerick pfeerick added this to the 2.10.2 milestone Jun 19, 2024
@pfeerick pfeerick added the house keeping 🧹 Cleanup of code and house keeping label Jun 19, 2024
@pfeerick
Copy link
Member Author

@3djc Did I miss anything here?

@3djc
Copy link
Collaborator

3djc commented Jun 19, 2024

@3djc Did I miss anything here?

Nop, that should work just fine. If you want to be picky, you could move the 2 inits above line 52 (GPIO_InitStructure.GPIO_Mode = GPIO_Mode_IN;) and for each drop "GPIO_InitStructure.GPIO_Mode = GPIO_Mode_OUT;"

@pfeerick
Copy link
Member Author

Thanks... and done... might as well! :)

@pfeerick pfeerick merged commit be2340c into 2.10 Jun 19, 2024
45 checks passed
@pfeerick pfeerick deleted the pfeerick/210-5190 branch June 19, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants