fix(x9e): missing F3/F4 pots, slider hwdef changes #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3djc
added
B&W
|
Changing the hw def will likely break Companion binary and adc refactor conversions as I seem to remember a specific fudge. |
|
I guess it is likely currently broken as F3/F4 existed pre refactor, and had disappeared since |
|
I'll have a look when I get time |
|
Tested using 2.3.15 otx (binary) and 2.9.4 etx (yaml) and all appears okay. Back to you @3djc to check. |
pfeerick
changed the title
|
Do you want me to comment those out If I spot them before merging? |
|
Retested everything, seems good to me ! |
|
Thanks JC :) |
pfeerick
pushed a commit
that referenced
this pull request
May 20, 2024
Co-authored-by: elecpower <neilh713@tpg.com.au>
pfeerick
added a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match declaration with OTX initial source
Fixes #5006