fixcpn): use model semver over radio semver for decoding model sources and switches #4768
Conversation
elecpower
added
companion
pfeerick
force-pushed
the
elecpower/cpn-fix-4759-decode-v210
branch
from
97c30eb to
cf8c99d
Compare
| if (modelSettingsVersion > SemanticVersion(VERSION)) | ||
| qDebug() << "Warning: version not supported by Companion!"; | ||
| if (modelSettingsVersion > SemanticVersion(VERSION)) { | ||
| QString prmpt = QCoreApplication::translate("YamlModelSettings", "Warning: Model settings file version %1 is not supported by this version of Companion!\n\nModel and radio settings may be corrupted if you continue.\n\nI acknowledge and accept the consequences."); |
There was a problem hiding this comment.
Is it possible to display the model filename in question here? edit: I'm going to assume "not easily" as it appears to be working on just data of the file, so will merge this anyway, but with a plea that it give some idea as to which file is being a pain in the future if you are unlucky enough to be faced with this.
There was a problem hiding this comment.
A present the best I could do is display the model name and add a TODO reminder.
There was a problem hiding this comment.
That would be great in the interim - better than a bunch of non-descript "something ain't right" errors. Just thinking back to the other todo about the error handling, maybe that is where the filename could get exposed as part of the reason for failing.
Fixes #4759 and also display message for each model file where the version is ahead of Companion.