Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable S.PORT telemetry by default for SBUS and PPM modules #3986

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Sep 1, 2023

Fixes #3877

Summary of changes:

  • Enable S.PORT telemetry by default for SBUS and PPM modules.

@raphaelcoeffic raphaelcoeffic linked an issue Sep 1, 2023 that may be closed by this pull request
1 task
@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Sep 2, 2023
@pfeerick pfeerick modified the milestones: 2.9, 2.9.x Sep 2, 2023
@rotorman
Copy link
Member

rotorman commented Sep 2, 2023

Tested with RadioMaster TX16S mkII running Yaapu Lua Telemetry widget. MavlinkToPassthrough connected to Dragonlink TX. On model side, flight controller running ArduPlane and talking native MAVLink.

Result - telemetry data, via S.PORT passthrough, works with Yaapu Lua telemetry widget.

Update: I did not test the outgoing direction, thus if S.BUS out works.

@rotorman
Copy link
Member

rotorman commented Sep 2, 2023

Tested the S.BUS connectivity as well - also functions as it should - I see channel values in Mission Planner, connected at FC side, whereas DragonLink TX was connected via S.BUS.

@raphaelcoeffic raphaelcoeffic changed the title feat(sbus): enable S.PORT telemetry by default feat: enable S.PORT telemetry by default for SBUS and PPM modules Sep 15, 2023
@raphaelcoeffic raphaelcoeffic marked this pull request as ready for review September 15, 2023 10:42
@pfeerick pfeerick merged commit 2532162 into 2.9 Sep 22, 2023
@pfeerick pfeerick deleted the 2.9-sbus-enable-sport branch September 22, 2023 08:32
@pfeerick
Copy link
Member

pfeerick commented Sep 22, 2023

Is something also needed for 2.10 / main ?

@raphaelcoeffic
Copy link
Member Author

raphaelcoeffic commented Sep 22, 2023

Is something also needed for 2.10 / main ?

I don't think so, we should solve this in a better way in main. See #3780. I don't really like enabling S.PORT implicitly like that, but it's ok for 2.9 until we provide a better solution in main.

@pfeerick
Copy link
Member

Perfect... that one is up soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No sbus in 2.8.x but no telemetry in 2.9.x
3 participants