-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove legacy UI for telemetry type #3782
Conversation
5f04fa9
to
b278502
Compare
@raphaelcoeffic @pfeerick correct, this PR gets rid of the old zombie FrSky implementation which only made it half way into EdgeTX (b&W only), caused Companion to crash and created problems for a few users migrating from OpenTX on color radios. The good thing is it was hardly used anyways. #3352 can serve as a template how to do it right in #3780's spirit. Peter and I discussed the removal and are aware we might cause some (most likely only a handful) users a headache. The remedy would be to discuss the specific use case and extend the required module's capability as shown in #3352. The way the current old FrSky focused implementation handles things is incomplete and not worth keeping alive. |
Thx @mha1 this is real documentation for the posterity! |
From what I can tell, this is as expected. X9D+2019 doesn't have any issues in the telemetry screen as a consequence of this PR. I can't test the Companion side changes atm as it seems PPM is missing from the external module list atm (not related to this PR) but they look ok. |
Fixes #3776
Summary of changes: