Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): Add read/write for trainer multiplier in radio.yml #3694

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

elecpower
Copy link
Collaborator

Fixes #3693

@elecpower elecpower added bug 🪲 Something isn't working companion Related to the companion software labels Jun 18, 2023
@pfeerick
Copy link
Member

Ouch! Actually need to check #3501 for something similar, as with the recent changes I don't know yet if it will at least preserve any options present. I feel some of them can't be configured in Companion as they are dependent on runtime module and receiver settings/capabilities, so Companion just needs to not nuke them on a read/write cycle.

@pfeerick pfeerick added this to the 2.9 milestone Jun 19, 2023
@pfeerick pfeerick merged commit a288eb1 into main Jun 19, 2023
@pfeerick pfeerick deleted the elecpower/cpn-fix-trainer-multi branch June 19, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion not reading or writing trainer multiplier setting
2 participants