Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RX OTA flash for frsky X10s & X12s. #3687

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

isjfk
Copy link
Contributor

@isjfk isjfk commented Jun 16, 2023

Fixes #2147

Summary of changes:
The OTA flash code are basically copied from stdlcd, rewrite UI part based on the new implementation for color screens.

The UI part cost me some time. My finding is to close dialogs & menus programmatically, they needs to be deleteLater() in stack order, from latest widget to older widget. If the order is wrong the UI will crash immediately. After fix the order of deleteLater(), the UI works fine.

I run several tests in my X10s, click no and yes, flash by OTA several times. Seems working well in my device. It should also work in X12s, but I don't have a device to test.
X10s-OTA-flash

@ParkerEde
Copy link
Contributor

I have now tried this pull request.
I select "Flash by int. OTA", then it comes waiting for Rx. Now I plug the battery on the Rx (which is correctly bound and works) but unfortunately nothing happens. The receiver is not recognized and thus the flash process does not start. I test with X10SExpress and Archer R8pro

@ParkerEde
Copy link
Contributor

After I re-registered and bound the Rx again, the recognition of the Rx at power on worked and the flash process runs.

@pfeerick I would appreciate it if we could still include this pull request in version 2.9. Thanks a lot

@ParkerEde
Copy link
Contributor

I have now flashed more Archer R6 RX. All of them worked right away. Good job, thank you @isjfk

@pfeerick pfeerick self-assigned this Jun 28, 2023
@pfeerick
Copy link
Member

pfeerick commented Jun 28, 2023

That should be fine... really just need confirmation testing (since it's mainly just adding the missing UI bits) and you've provided that 😁

@pfeerick pfeerick added this to the 2.9 milestone Jun 30, 2023
@pfeerick pfeerick added bug 🪲 Something isn't working color Related generally to color LCD radios labels Jun 30, 2023
@pfeerick pfeerick merged commit 1255ff0 into EdgeTX:main Jun 30, 2023
@isjfk
Copy link
Contributor Author

isjfk commented Jul 5, 2023

@ParkerEde My pleasure! Thanks for your verification.

@isjfk
Copy link
Contributor Author

isjfk commented Jul 18, 2023

I have now tried this pull request. I select "Flash by int. OTA", then it comes waiting for Rx. Now I plug the battery on the Rx (which is correctly bound and works) but unfortunately nothing happens. The receiver is not recognized and thus the flash process does not start. I test with X10SExpress and Archer R8pro

Seems if the model was upgraded from OpenTX, the receiver still work but it cannot be bind again or OTA flashed. It never shown up in the list. I have my X-Lite upgrade yesterday, although it's not a color screen by exactly same issue happen.

Probably because the Owner ID was changed during the upgrade. My Owner ID changed to some random chars that cannot be displayed correctly. Have to reset the Owner ID in TX, delete the receiver, register & bind again to make it OTA flash-able (just like you did).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrSky X12S ISRM/ACCESS missing flash RX by int. OTA option on .frsk files
4 participants