Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external MPM flash #3671

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix: external MPM flash #3671

merged 1 commit into from
Jun 20, 2023

Conversation

mha1
Copy link
Contributor

@mha1 mha1 commented Jun 9, 2023

Summary of changes:

  • specific pulse timer inits for and pwm toggle mode
  • set correct RX/TX polarity for MPM bootloader
  • extended flash process timeout from 12.5ms to 100ms as robustness measure

@pfeerick pfeerick requested a review from raphaelcoeffic June 9, 2023 07:36
@pfeerick
Copy link
Member

pfeerick commented Jun 9, 2023

@raphaelcoeffic I've only tried this on the TX16S with external MPM, but it has resolved the flashing issue for that. I did a bisect and asked Michael to take a look at it, as it all went horribly wrong at (prior to that, there was the occasional mid-flash failure, but this PR onwards introduced complete inability to flash.

Next up will be TX12, X9D+ and external MPM, and also an STM32 ELRS module.

6aa1fc90c483ad29c8c12e6eba596f276d83aa18 is the first bad commit
commit 6aa1fc90c483ad29c8c12e6eba596f276d83aa18
Author: Raphael Coeffic <raphaelcoeffic@users.noreply.github.com>
Date:   Fri May 5 11:20:29 2023 +0200

    fix: signal polarity for soft-serial & timer based protocols (#3513)

@ParkerEde
Copy link
Contributor

I tested this PR with the Horus X10S Express and the TARANIS QX7S ACCESS. The ext. MPM could be flashed correctly

@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Jun 19, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jun 19, 2023
@pfeerick pfeerick self-assigned this Jun 19, 2023
@mha1
Copy link
Contributor Author

mha1 commented Jun 19, 2023

As a proud owner of a new external RM 4in1 MPM I can confirm flashing the module is not working in main but working with this PR (as it did with my ext MPM flash PC simulator)

@pfeerick
Copy link
Member

Perfect timing Maestro!

  • RM TX12 w/ iRange 4in1 MPM 🟢
  • Frsky X9D+ w/ RM 4in1 MPM 🟢
  • RM TX12MK2 w/ HM ES915TX ELRS 🟢
  • Jumper T-Pro internal MPM & external RM 4in1 MPM 🟢

@pfeerick pfeerick merged commit fa490e5 into EdgeTX:main Jun 20, 2023
@mha1
Copy link
Contributor Author

mha1 commented Jun 20, 2023

Thank you

@mha1 mha1 deleted the ext_MPM_flash branch July 6, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants