Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the messy display after Boxer shutdown #3654

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

zyren
Copy link
Contributor

@zyren zyren commented Jun 3, 2023

Solve the redundant cluttered display on the screen after Boxer is shut down.

Solve the redundant cluttered display on the screen after Boxer is shut down.
@3djc
Copy link
Collaborator

3djc commented Jun 3, 2023

Is it all RM radio with f4 ? If yes, it would be more future proof to state those instead of specific radio names ?

@zyren
Copy link
Contributor Author

zyren commented Jun 3, 2023

Yes, this issue occurs on all F4 radios, including Zorro, TX12MK2, and BOXER. When the radio is turned off, after a while, the screen displays random lines. Please refer to #2155. This issue does not occur on the TX12 of F2.

@3djc
Copy link
Collaborator

3djc commented Jun 4, 2023

Then maybe replace by this, so it cover existing and new models:
#if defined(MANUFACTURER_RADIOMASTER) && defined(STM32F407xx)

@zyren
Copy link
Contributor Author

zyren commented Jun 4, 2023

Okay, I will make the changes and submit a new PR. Is that alright?

#if defined(MANUFACTURER_RADIOMASTER) && defined(STM32F407xx)
        lcdInit();
#endif

@3djc
Copy link
Collaborator

3djc commented Jun 4, 2023

You can update this PR, just update the branch and push it, that will update this PR without the need to create a new one :)

@pfeerick
Copy link
Member

pfeerick commented Jun 8, 2023

@3djc Do you think this actually needs to be RM specific? Regardless of the radio, is there any harm in doing this on B&W generally, since it is essentially a screen clear on power off?

@3djc
Copy link
Collaborator

3djc commented Jun 8, 2023

Shouldn't be an issue to do it for all radio, but since no one ever reported an issue on the other ones, I tend to think "if it ain't broken, don't fix it". Happy both ways anyway :)

@pfeerick
Copy link
Member

pfeerick commented Jun 8, 2023

Very true. I've actually noticed this on the TX12 (not sure offhand if it was the TX12 or TX12MKII), and have never really thought anything more of it since the radio is powering off. I agree with that philosophy... if someone else suggests it's needed later, it's just a matter of removing the define 🤷 😆

@pfeerick pfeerick added bug 🪲 Something isn't working B&W Related generally to black and white LCD radios labels Jun 8, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jun 8, 2023
@pfeerick pfeerick merged commit 3a32c8d into EdgeTX:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants