Fix: first channel omitted in PPM stream #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mha1
force-pushed
the
fix_PPM_channel_missing
branch
from
c8cc8a5 to
21dc3df
Compare
1 task
mha1
force-pushed
the
fix_PPM_channel_missing
branch
2 times, most recently
from
bd30872 to
b938d50
Compare
|
LGTM on TX16S, TX12 MK2 and X9D+2019... prior to this PR there were seven pulses, with the first channel missing (when configured with defaults - 8CH)... looks like the first was merged into the second? After this PR all eight are present and accounted for 🤭 |
pfeerick
approved these changes
May 23, 2023
mha1
force-pushed
the
fix_PPM_channel_missing
branch
from
b938d50 to
d68c984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3597
PPM settings for external module:
PPM stream with internal RF set to OFF and external RF set to PPM with above settings -
OKAll sticks at neutral except CH1 set to Min. Channel monitor confirms all channel 1 at 988us, channels 2 to 8 at 1500us. Notice all 8 channels correctly transmitted, timing as expected.
PPM OFF to PPM ON without glitches - -
OK