Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formating the sd card is a bad idea with EdgeTX #3549

Merged
merged 1 commit into from
May 1, 2023
Merged

Formating the sd card is a bad idea with EdgeTX #3549

merged 1 commit into from
May 1, 2023

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Apr 30, 2023

Reduce risk AND reduce flash size by 1928 bytes

@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label May 1, 2023
@pfeerick pfeerick added this to the 2.9 milestone May 1, 2023
@pfeerick
Copy link
Member

pfeerick commented May 1, 2023

I think we'll need to resurrect this for PL18 and also possibly targets that also have onboard flash (i.e. TX16S, NV14, EL18) when virtual-fs is enabled, but that is a problem for then... this reclaims enough memory that all the translated targets should build for the x9d+2019, as it was clearly still overflowing for EN, but was definitely falling over for any translations.

@pfeerick pfeerick merged commit f5c1a93 into main May 1, 2023
@pfeerick pfeerick deleted the 3djc/remove-sdformat branch May 1, 2023 23:30
@gagarinlg
Copy link
Member

I think we'll need to resurrect this for PL18 and also possibly targets that also have onboard flash (i.e. TX16S, NV14, EL18) when virtual-fs is enabled, but that is a problem for then... this reclaims enough memory that all the translated targets should build for the x9d+2019, as it was clearly still overflowing for EN, but was definitely falling over for any translations.

I will take care of that when preparing the PL18 code for merging

ulfhedlund added a commit to ulfhedlund/edgetx that referenced this pull request May 6, 2023
@ulfhedlund
Update for PR EdgeTX#3549
4a87812 
TR_SD_FORMAT and TR_FORMATTING strings removed
ulfhedlund added a commit to ulfhedlund/edgetx that referenced this pull request May 6, 2023
@ulfhedlund
Update for PR EdgeTX#3549
18cb9c5 
TR_SD_FORMAT and TR_FORMATTING strings removed
mha1 pushed a commit to mha1/edgetx that referenced this pull request May 7, 2023
@3djc @mha1
fix: Formatting the SD card on radio when running is a bad idea (Edge…
0ffedb2 
…TX#3549)

Plus we need the flash memory space for some targets!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
3 participants
@3djc @pfeerick @gagarinlg