-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color) - Change Flight Mode list and edit views. #3344
Conversation
Wow, great. |
Not that I am aware of - or more specifically, none that are supported in code yet. There is another radio that has more trims, but it's not supported yet, so is a non-issue for now.
It's to allow you to check what effect the active FM trims have - FM trims are temporarily disabled. |
I would like to defer any significant changes from the current implementation until later, as there are still some major UI changes ahead as we lead up to 3.0, so all this PR should focus on at present is making the UI more consistent with the rest of the screens, and improving usability, which I think it has achieved. But please continue to make suggestions, the more ideas the better! I particularly like that idea about back/previous arrows in the header - perhaps that is something we somehow consider for any of the edit screens. |
I think we should merge this as-is and wait for feedback with 2.9 |
- Update trim ranges in Companion to match radio. - Move trims setup to main edit view instead of dialog popup. - Show/edit current trim value for each trim (if enabled)
Reduces build time on TX16S Mk2 from ~320ms to ~25ms.
Fixes #2062
Summary of changes:
The list view layout is a bit messy; but I'm not sure how to do it any cleaner.
The list view can only handle 6 trim switches at the moment - I hope there aren't any radios with more.
The trim values in the list view will update automatically if the trim is altered via the trim switches (probably need to do this in the edit page as well).
I left the 'Check FM Trims' button at the bottom, although I don't really understand it's purpose. It will however now turn off automatically when the timer runs out.