Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color) - Change Flight Mode list and edit views. #3344

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Mar 11, 2023

Fixes #2062

Summary of changes:

  • Move trim setup to FM edit page instead of being a popup
  • Add trim value display/edit box to FM edit page (only displayed if enabled)
  • Display FM list like logical switches, show all FM data for each mode
  • Update the trim value range limits in Companion to match the radio

The list view layout is a bit messy; but I'm not sure how to do it any cleaner.
The list view can only handle 6 trim switches at the moment - I hope there aren't any radios with more.

The trim values in the list view will update automatically if the trim is altered via the trim switches (probably need to do this in the edit page as well).

I left the 'Check FM Trims' button at the bottom, although I don't really understand it's purpose. It will however now turn off automatically when the timer runs out.

Screen Shot 2023-03-11 at 2 26 06 pm

Screen Shot 2023-03-11 at 2 37 44 pm

Screen Shot 2023-03-11 at 2 26 34 pm

Screen Shot 2023-03-11 at 2 26 49 pm

@Eldenroot
Copy link
Contributor

Wow, great.

@pfeerick pfeerick added this to the 2.9 milestone Mar 13, 2023
@pfeerick
Copy link
Member

The list view can only handle 6 trim switches at the moment - I hope there aren't any radios with more.

Not that I am aware of - or more specifically, none that are supported in code yet. There is another radio that has more trims, but it's not supported yet, so is a non-issue for now.

I left the 'Check FM Trims' button at the bottom, although I don't really understand it's purpose. It will however now turn off automatically when the timer runs out.

It's to allow you to check what effect the active FM trims have - FM trims are temporarily disabled.

@neuhausj
Copy link

First of all congratulation for this PR.
It looks already much better and a good step in the right direction.

  1. To improve the readability of the FM overview further, an even simpler layout could be welcome by removing the rounded borders around the FM.
    Something like the old overview, and maybe have an alternate light color background. (similar to this screenshot)
    image

  2. We can also present a FM selection menu instead of having to tap the correct FM directly from the overview list.
    This would allow both high density overview + easy FM selection. Back button is still missing here.
    image

  3. Another potential improvement from the edit view, would be to add a next / previous selection arrow in the header, to move directly to the next/previous FM settings.
    image

Those are only ideas and feel free to discuss/critize them to end up with a beautiful UI !
Thanks again !

@pfeerick
Copy link
Member

pfeerick commented Mar 15, 2023

I would like to defer any significant changes from the current implementation until later, as there are still some major UI changes ahead as we lead up to 3.0, so all this PR should focus on at present is making the UI more consistent with the rest of the screens, and improving usability, which I think it has achieved. But please continue to make suggestions, the more ideas the better! I particularly like that idea about back/previous arrows in the header - perhaps that is something we somehow consider for any of the edit screens.

@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Mar 15, 2023
@gagarinlg
Copy link
Member

I think we should merge this as-is and wait for feedback with 2.9

Phil Mitchell added 7 commits March 27, 2023 09:09
- Update trim ranges in Companion to match radio.
- Move trims setup to main edit view instead of dialog popup.
- Show/edit current trim value for each trim (if enabled)
Reduces build time on TX16S Mk2 from ~320ms to ~25ms.
@pfeerick pfeerick merged commit ebef94d into EdgeTX:main Mar 27, 2023
@philmoz philmoz deleted the fm-layout branch October 18, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for touch friendly graphics
5 participants