Replace StaticText with LVGL labels.

[philmoz]

Getting rid of the StaticText labels and using LVGL labels instead also improves the load time.

[philmoz]

I did some timing tests with the simulator on my iMac.

Time (in nanoseconds) to build the GVARS page:

• The current main branch = 1828000
• EdgeTX/gvars_speedup branch = 1537000 (84%)
• EdgeTX/gvars_speedup + EdgeTX/libopenui/speedup = 1252000 (68%)
• philmoz/gvars_speedup = 817000 (45%)

While the libopenui changes certainly help, removing the StaticText and Window objects entirely from the GVarButton class gives the biggest improvement.

[gagarinlg]

Wow
Maybe you could disabe the clock and printf stuff again? I will then accept the PR in my branch.

[philmoz]

I've removed all the diagnostics.

[gagarinlg]

Did you test this with the NV14 simu?

[philmoz]

Did you test this with the NV14 simu?

Oops - I was a bit too aggressive with the optimisation. Fixed now.

[gagarinlg]

😂👍
There was a reason I added that container window

[philmoz]

I've separated the style from the widget and used state to change the background colour and font size.
This is a tiny bit slower but hopefully not noticeable.

[philmoz]

The latest commit further improves the performance on the GVARS page.
The overall time to display the page content is better; but the main improvement is the initial object creation time is drastically reduced by delaying the main content initialisation.

This improves the responsiveness when navigating between tabs - there is no longer a big delay on this page before you can move to another tab.

[pfeerick]

Can you rebase this one for me... it looks like it will be a clean rebase, but if you do git won't assign dual authorship to the commits ;)

Am I right in believing that this effectively supersedes #3307. And merging in EdgeTX/libopenui#88 shouldn't break anything in conjunction with this? Just double checking as it seems to all be working fine here 😇

[philmoz]

I rebased to main; but it is showing a conflict with model_gvars.cpp - not sure what I did wrong?

The libopenui PR should be fine.

[pfeerick]

Ah, sorry, I'm an idiot... I didn't look at the target branch and was thinking it was to go into main, not Malte's speedup branch, 🤦 Ok, I'll just try something, and if that doesn't work, can go via that branch... maybe 😆

edit: Looks like that did what it should have, since this was rebased on main.