Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix INRM301 failsafe BUG #3298

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix INRM301 failsafe BUG #3298

merged 3 commits into from
Mar 22, 2023

Conversation

Xy2019
Copy link
Contributor

@Xy2019 Xy2019 commented Mar 4, 2023

Fixes #3297

Summary of changes:

@pfeerick pfeerick added the bug 🪲 Something isn't working label Mar 5, 2023
@pfeerick pfeerick added this to the 2.8.2 milestone Mar 5, 2023
@richardclli richardclli self-requested a review March 7, 2023 02:03
Copy link
Collaborator

@richardclli richardclli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems finally got a way to do boardOff properly without entering emergency mode in next power on.

@richardclli
Copy link
Collaborator

richardclli commented Mar 7, 2023

@raphaelcoeffic Please take a look in the protocol part, @Xy2019 is Flysky's programmer, he will help to fix problems from now on.

@Xy2019
Copy link
Contributor Author

Xy2019 commented Mar 7, 2023

Seems finally got a way to do boardOff properly without entering emergency mode in next power on.

The last modification would lead to emergency mode, so I re-modified and submitted it.

@richardclli
Copy link
Collaborator

richardclli commented Mar 8, 2023

@Xy2019 it would be better to split PR so that each PR only fix one issue. Hard to review and merge if mixed together.

@Xy2019
Copy link
Contributor Author

Xy2019 commented Mar 8, 2023

@Xy2019 it would be better to split PR so that each PR only fix one issue. Hard to review and merge if mixed together.

OK, I tried to resubmit.

@pfeerick
Copy link
Member

pfeerick commented Mar 10, 2023

Seems finally got a way to do boardOff properly without entering emergency mode in next power on.

Not quite... while this mostly works, I naturally found one instance where it still triggers... which is if USB was active (i.e. SD mode) when you power down, it will indeed startup fine and show the charge screen. But the next time the radio powers on, it will EM.

Maybe needs to be handled at the charge screen so that UNEXPECTED_SHUTDOWN() is not true in that edge case. Then again, if it encourages people to NOT power off the radio while the SD card is still mounted (ok, ok, I know this also means joystick mode)... I'm not complaining 😁

@Xy2019 Can you remove the change to board.cpp now as the changes were merged as part of #3325

@Xy2019 Xy2019 changed the title fix EL18 Automatic power on and INRM301 failsafe BUG fix INRM301 failsafe BUG Mar 10, 2023
@pfeerick pfeerick self-assigned this Mar 16, 2023
@pfeerick
Copy link
Member

Seems to be working perfectly on EL18 w/ Ftr12B - can now set custom failsafe.

@pfeerick pfeerick merged commit 366242e into EdgeTX:main Mar 22, 2023
@Xy2019 Xy2019 deleted the INRM301-FailSafe branch March 22, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EL18 internal AFHDS3RF failsafe cannot be set successfully
3 participants