-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix INRM301 failsafe BUG #3298
fix INRM301 failsafe BUG #3298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems finally got a way to do boardOff properly without entering emergency mode in next power on.
@raphaelcoeffic Please take a look in the protocol part, @Xy2019 is Flysky's programmer, he will help to fix problems from now on. |
The last modification would lead to emergency mode, so I re-modified and submitted it. |
@Xy2019 it would be better to split PR so that each PR only fix one issue. Hard to review and merge if mixed together. |
OK, I tried to resubmit. |
Not quite... while this mostly works, I naturally found one instance where it still triggers... which is if USB was active (i.e. SD mode) when you power down, it will indeed startup fine and show the charge screen. But the next time the radio powers on, it will EM. Maybe needs to be handled at the charge screen so that @Xy2019 Can you remove the change to |
Seems to be working perfectly on EL18 w/ Ftr12B - can now set custom failsafe. |
Fixes #3297
Summary of changes: