Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: SDIO conversion to HAL #3182

Merged
merged 2 commits into from
Aug 13, 2023
Merged

chore: SDIO conversion to HAL #3182

merged 2 commits into from
Aug 13, 2023

Conversation

gagarinlg
Copy link
Member

Summary of changes: move SDIO to HAL

@gagarinlg gagarinlg marked this pull request as ready for review May 4, 2023 21:19
@raphaelcoeffic
Copy link
Member

@gagarinlg should we first introduce the new FatFs API and base on that? What do you think?

@raphaelcoeffic raphaelcoeffic marked this pull request as draft August 12, 2023 05:34
@gagarinlg
Copy link
Member Author

This should be OK without the new API. The branch for the SPI based radios will introduce the new API

@raphaelcoeffic raphaelcoeffic force-pushed the gagarinlg/sdio branch 3 times, most recently from ff0808b to 053ab0c Compare August 12, 2023 08:44
@raphaelcoeffic raphaelcoeffic marked this pull request as ready for review August 12, 2023 09:02
@3djc
Copy link
Collaborator

3djc commented Aug 12, 2023

Tested on TX16S:
browsing sd filesystem: ok
running various scripts: ok
running 0.1s logs while hamering a playTrack function: ok
Could not break it

@raphaelcoeffic raphaelcoeffic force-pushed the gagarinlg/sdio branch 3 times, most recently from 53c8e96 to 7394ba6 Compare August 13, 2023 15:24
This should fix race conditions with dependencies on the JSON file.
@raphaelcoeffic raphaelcoeffic merged commit b377a8b into main Aug 13, 2023
@raphaelcoeffic raphaelcoeffic deleted the gagarinlg/sdio branch August 13, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants