Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nv14): start SysTick prior to using I2C HAL code #3175

Closed
wants to merge 1 commit into from
Closed

fix(nv14): start SysTick prior to using I2C HAL code #3175

wants to merge 1 commit into from

Conversation

raphaelcoeffic
Copy link
Member

Fixes #3155

@raphaelcoeffic raphaelcoeffic mentioned this pull request Feb 11, 2023
Closed
@raphaelcoeffic raphaelcoeffic added this to the 2.8.1 milestone Feb 11, 2023
@raphaelcoeffic
Copy link
Member Author

raphaelcoeffic commented Feb 11, 2023 •
edited
Loading

Side note: we might consider starting SysTick ahead of the FreeRTOS scheduler in any case, due to the HAL code relying on it. In case we do, it would be wise to double check with FreeRTOS on their forum if that is the right thing to do.

This thread suggests this is not the right thing to do: https://forums.freertos.org/t/increment-xtickcount-before-call-of-vtaskstartscheduler/6763/5

@raphaelcoeffic raphaelcoeffic deleted the fix-3155 branch February 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagarinlg gagarinlg Awaiting requested review from gagarinlg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

EL18 may crash when you touch the screen while charging
1 participant
@raphaelcoeffic