Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: B&W MPM protocol offset, subprotocol lists too long #3112

Merged
merged 2 commits into from
Jan 27, 2023
Merged

fix: B&W MPM protocol offset, subprotocol lists too long #3112

merged 2 commits into from
Jan 27, 2023

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Jan 26, 2023 •
edited
Loading

Fixes issues post #3032 whereby:

  • protocol list was completely unusable on B&W radios
  • subprotocol lists for some Frsky protocols were too long

Tested with:

  • TX16, internal MPM, Frsky X and Frsky X2 receivers bound and telemetry scan.
  • TX12MK2, external MPM, same as above.
  • X9D+, external MPM, same as above.
  • NV14, external MPM, same as above.

@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Jan 26, 2023
@pfeerick pfeerick added this to the 2.8.1 milestone Jan 26, 2023
@pfeerick pfeerick changed the title B&W MPM protocol offset, subprotocol lists too long fix: B&W MPM protocol offset, subprotocol lists too long Jan 26, 2023
@3djc
Copy link
Collaborator

3djc commented Jan 26, 2023

Tested ok with eu mpm firmware

@pfeerick pfeerick merged commit 93865ba into main Jan 27, 2023
@pfeerick pfeerick deleted the mpm-cleanup branch January 27, 2023 05:28
mha1 pushed a commit to mha1/edgetx that referenced this pull request Jan 27, 2023
@pfeerick @mha1
fix: B&W MPM protocol offset, subprotocol lists too long (EdgeTX#3112)
947dfe2 
* fix: Off by one error for protocol list
* fix: Incorrect range for some Frsky subprotocols
pfeerick added a commit that referenced this pull request Feb 3, 2023
@pfeerick
fix: B&W MPM protocol offset, subprotocol lists too long (#3112)
ea43d07 
* fix: Off by one error for protocol list
* fix: Incorrect range for some Frsky subprotocols
pfeerick added a commit that referenced this pull request Feb 3, 2023
@pfeerick
fix: B&W MPM protocol offset, subprotocol lists too long (#3112)
8c44b00 
* fix: Off by one error for protocol list
* fix: Incorrect range for some Frsky subprotocols
@pfeerick pfeerick mentioned this pull request Mar 19, 2023
Merged
@richardclli richardclli mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pfeerick @3djc