Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) - Trainer setup layout #3104

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jan 25, 2023

Update the trainer setup page layout to:

  • remove small amount of scroll of landscape layout
  • use available space on portrait layout

Screen Shot 2023-01-24 at 8 44 02 am

Screen Shot 2023-01-24 at 7 34 35 am

@froqstar
Copy link

Isn't there enough space to replace the := and += with text like "replace" and "add"?
Would be more user friendly IMHO.

@pfeerick
Copy link
Member

There should be... and I don't see why not... the Multiplex option for mixes is also spelled out, so it would also be consistent with how it's shown there.

@philmoz
Copy link
Collaborator Author

philmoz commented Jan 26, 2023

Isn't there enough space to replace the := and += with text like "replace" and "add"?
Would be more user friendly IMHO.

This will require changing the TR_TRNMODE string and getting translations for 'Replace' and 'Add' for all languages.
The layout will then need to be tweaked to fit the longest translated string.

I should be able to get the translations from the TR_VMLTPX strings in the language files.

@pfeerick
Copy link
Member

pfeerick commented Jan 26, 2023

#define TR_VMLTPX                      "Add","Multiply","Replace"

;)

@philmoz philmoz force-pushed the trainer-setup-layout branch 2 times, most recently from 3827491 to 410cdcf Compare February 1, 2023 21:46
@pfeerick pfeerick added the color Related generally to color LCD radios label Feb 6, 2023
@pfeerick pfeerick added this to the 2.9 milestone Feb 6, 2023
@pfeerick pfeerick added the UX-UI Related to user experience (UX) or user interface (UI) behaviour label Feb 6, 2023
@pfeerick pfeerick self-assigned this Feb 6, 2023
@philmoz philmoz force-pushed the trainer-setup-layout branch from 410cdcf to ba26c02 Compare February 12, 2023 03:56
@pfeerick pfeerick merged commit 00c3851 into EdgeTX:main Feb 13, 2023
@JimB40 JimB40 mentioned this pull request Feb 21, 2023
23 tasks
@3djc 3djc mentioned this pull request Mar 14, 2023
1 task
@philmoz philmoz deleted the trainer-setup-layout branch September 20, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants