fix(cpn) - Fix joystick slider mappings in companion. #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on where you noticed the 7 pots, this could be one of the infamous storage schemes that have evolved over time. But other logic redefines. |
|
|
|
|
|
TX16S has facility for an extra 2 analog inputs as standard (EX1 & EX2), and two more can be gained when using the flysky digital gimbals (EX3 & EX4). This is unfortunately where runtime detection rears its ugly head - i.e. if you don't have the digital gimbals connected, you'll see you only have five entries under POTS on the radio - S1/6P/S2/EX1/EX2 |
pfeerick
added
companion
mha1
pushed a commit
to mha1/edgetx
that referenced
this pull request
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my TX16S the sliders could be seen in the companion joystick setup; but would not connect to the simulator widgets regardless of the mapping option selected in the dropdown.
The index being passed to the widgetValueChanged event was incorrect.
Note: On the TX16S the LS and RS sliders should be mapped to Knob/Slider 8 and Knob/Slider 9 respectively. They will then control the simulator widgets correctly.
For some reason the companion code setup thinks the TX16S has 7 pots ???