Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) - Add long press handler for new model curves page. #3091

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jan 23, 2023

Align with new special function and proposed logical switch UI.
Also adds titles to the menus to make it clearer what action is being performed.

Short press:
Screen Shot 2023-01-24 at 8 36 32 am

Long press:
Screen Shot 2023-01-24 at 8 36 48 am

@pfeerick pfeerick self-assigned this Jan 24, 2023
@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Jan 24, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jan 24, 2023
@pfeerick pfeerick merged commit 820a924 into EdgeTX:main Jan 24, 2023
@ParkerEde
Copy link
Contributor

Unfortunately, I still have a question about this. In the current implementation, it is no longer possible to specifically create a curve as a certain ID. This means that the curves cannot be sorted into blocks according to task. It would be nicer if the (+) button offered a list of free curves and the new curve was then created on the selection. This would be exactly the same as with the specialfunctions or logicalswitches. Could this also be implemented here?

@philmoz
Copy link
Collaborator Author

philmoz commented Jan 24, 2023

Unfortunately, I still have a question about this. In the current implementation, it is no longer possible to specifically create a curve as a certain ID. This means that the curves cannot be sorted into blocks according to task. It would be nicer if the (+) button offered a list of free curves and the new curve was then created on the selection. This would be exactly the same as with the specialfunctions or logicalswitches. Could this also be implemented here?

Good idea - let me take a look.

@Eldenroot
Copy link
Contributor

Unfortunately, I still have a question about this. In the current implementation, it is no longer possible to specifically create a curve as a certain ID. This means that the curves cannot be sorted into blocks according to task. It would be nicer if the (+) button offered a list of free curves and the new curve was then created on the selection. This would be exactly the same as with the specialfunctions or logicalswitches. Could this also be implemented here?

always good to create a new ticket.

@pfeerick
Copy link
Member

always good to create a new ticket.

... if the PR isn't self explanatory, or are unsure as to whether will actually work on it. ;) Otherwise, it's just added noise.

@ParkerEde
Copy link
Contributor

Should I create a new ticket or what do you suggest?

@pfeerick
Copy link
Member

What for... #3091 ? 😆

mha1 pushed a commit to mha1/edgetx that referenced this pull request Jan 27, 2023
@philmoz philmoz deleted the curves-long-press branch September 20, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants