feat(ui): Value widget text alignment options #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotorman
added
enhancement ✨
…right border of the widget zone.
rotorman
force-pushed
the
valueWidgetAlignRightOpt
branch
from
183ed18 to
0d2458d
Compare
|
CZ is fine, just only one typo (it was here before your PR, if you can fix it in this PR would be nice). Thx! |
|
@rotorman I assume you would like me to sync Companion so got it |
Sure, what should I fix? @elecpower yes, please! Thx! |
|
I added a comment |
|
@rotorman done |
@Eldenroot Just FYI - it says pending in that screenshot - so you didn't actually submit the comment/review... hence why it didn't show up ;) |
pfeerick
approved these changes
Feb 20, 2023
pfeerick
added
documentation
|
Would it be possible to also add these options to the "Text" widget as well? |
|
@phileville Please see PR #3574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new options to value widget to align label and value optionally also to center or right border of the widget zone:
I tried my best with translations, but am pretty sure that there are some languages that I did not manage to match perfectly.