Revised Special & Global Functions layout.

[philmoz]

Summary of changes:

• Convert the page to use the flex layout
• Move the function name into the button control for an active function so the entire row acts as a button
• Displays the active functions first with fixed height for each line
• Displays the inactive functions second as a grid so there is less to scroll through

[froqstar]

What if, instead of listing all the inactive special functions, we just have an "add" button at the bottom like we have with mixes?

[philmoz]

You can select one of the active functions and then choose 'Copy' from the menu.
Then on an inactive one you can choose 'Paste' from the menu.

With just an 'Add' button it would be more difficult to manage the copy/paste.

Also I like to use certain function numbers for the same operation across different models. I find it easier to manage this way. With just an 'Add' button it would be harder to pick a specific function to edit.

[Eldenroot]

Nice improvement

[ParkerEde]

This implementation is certainly good for touch operation. However, it is a degradation for non-touch color displays. I have for example from SF2 to SF20 some functions and in the range 50 to 64. If I now want to create SF1, you have to scroll a lot (up or down) to get to the button SF1. This implementation should only be used for touch radios, if at all. I personally have the feeling that with this implementation a lot of clarity is lost.
One suggestion: If there was a button in the headline row that would take you directly to the top of the free SF buttons, it would make it much easier to reach them.

[Eldenroot]

OK, but I think it is a good start :) we ca discuss :)

[pfeerick]

However, it is a degradation for non-touch color displays. I have for example from SF2 to SF20 some functions and in the range 50 to 64. If I now want to create SF1, you have to scroll a lot (up or down) to get to the button SF1.

How is that different from the current behaviour, in which a similar complaint could be made, since it is a fixed table, and you have to scroll through all the rows regardless of if there are entries present or not, rather than just scroll through the rows with content?

However, I do get that coming from fixed table view, how this can be seen as a loss of clarity, as sometimes you leave blank SFs so you can group SFs related together, etc.

You can select one of the active functions and then choose 'Copy' from the menu.
Then on an inactive one you can choose 'Paste' from the menu.

This is actually something I find lacking in the new Mixer layout... before, you could copy an existing mixer line into a specific new one... i.e. what if I want to assign something to channel 32 on a five-channel model? (yes, that is a thing - for some special mixes and working with some lua scripts). Before I could just copy, scroll to 32, and paste. Now I have to create 32, then copy and well, um... there's no paste anymore (only paste before and after)... ok... that's because paste only appears for empty mixer lines... oh dear.

[philmoz]

Away from main system at the moment so I can't try things; but a couple of thoughts:

• long press of enter button in SF/GF window to scroll to the first inactive function
• long press to bring up menu with options like 'Select first inactive', 'Add new', ...

[philmoz]

I have added a long press handler that will jump to the first free function (if pressed on an active function), or the first active function if pressed on a free function.

[ParkerEde]

Yes, this is now much easier to use thanks to the long press handler. Really good. One small problem has now come to my attention.
Assumed I have 10 SF rows. If I "delete" the second table entry (not "delete row"), the cursor jumps to the second free SF button. I think it would be clearer if it jumps to the next existing entry. What do think about it?

[philmoz]

@ParkerEde The code currently tries to re-select the entry number that was focussed before any operation.

For example suppose you have SF1, SF2 and SF4 as active functions and SF3 as an empty one.
If you delete SF2, then all the functions move up 1, so SF3 becomes SF2, SF4 becomes SF3, etc.

When SF2 is re-selected as the focussed function it is still an empty one so the screen jumps to show it.

If you clear an active function it will become empty; but remain focussed so the screen will again scroll to the empty function section.

[ParkerEde]

@philmoz
Just to make sure there is no misunderstanding here. I have only selected "Clear". The following lines do not move up and the cursor jumps away. Here I would find it clearer, it would simply jump to the next existing entry.

If I select "Delete" , where SF3 then becomes SF2, SF4 then SF3 etc., it already works correctly.

Sorry, I just built the EN version to be able to name the correct menu item

[philmoz]

@ParkerEde I understand what you are saying - I was just trying to explain how the logic currently works. I need to think about it more to see if I can come up with an alternative.

[ParkerEde]

@philmoz Perfect. Many many many thanks for your effort.

[philmoz]

After using this some more, and trying it with some non-technical club members, I've decided to revert the list to the original numerical sort order. Although the grouped order looked nicer it is not intuitive to use.

Where possible the empty functions are still grouped on a single line to reduce the vertical size.

I have also made the button press handling consistent by always having a popup context menu. As well as being consistent behaviour it means you can use the insert and delete actions on empty function to manage the list.

[ParkerEde]

I like it better that way, too. The overview is also restored. "Clear" and "Delete" also works well again. Good work.

[ParkerEde]

I've checked last state 66d9f54
The cursor always jumps to the top after "Clear" or "Delete". With "Clear" the same line should remain marked and with "Delete" the next entry present in the list should be jumped to.

[philmoz]

@ParkerEde Thanks for testing - should be fixed now.

[JimB40]

@philmoz Please unify lists visually changing to flex.
Visually SF List is same like Outputs.
Part of 2.9 goal is to unify UI/UX

In terms of indexing (if to show free numeric slots, how to design UX of adding & displaying) we have to discuss

[philmoz]

@JimB40 Do you mean like this? If I use the button style from the the model outputs page then functions that are active (i.e. their switch is on) show with the background as light blue (secondary3 colour) instead of yellow (active colour).

[JimB40]

As agreed. Use Inpusts/Mixes styling for list and I'm making issue to fix ACTIVE color in this style.

edit: #3021

[ParkerEde]

checked a98e9b3
It looks good for me now.

[JimB40]

Btw @philmoz I have checked data variances and it can be hard to fit all of them in one line

Examples of longest

• Switch - !WWWW (telemetry sensor name) + switch icon
• Func - "Set Main Screen"

Then parameters depoendent on Func type
Set

• Timer - "Timer 3"
• Value - "08:59:59

Adjust

• Global var - "GV5"
• Mode - "Inc/Decrement"
• Inc/Decrement - "+= 2048"

Play Track

• Value - 'WWWWWW' (wav filename 6 characters) + icon

Set Main Screen

• Value - "5"

Then for some of functions
Repeat - "60s"

For others
Enable - check box

By the way does anybody know what is purpose on Enable switch???
This feature is implemented for half of functions types

[pfeerick]

By the way does anybody know what is purpose on Enable switch???
This feature is implemented for half of functions types

Literally that - it enables or disables that SF/GF. The fact that it is not implemented for all is annoying... i.e. I'd like to have a Screenshot GF, but disable it so that it's configured but doesn't hog the switch until I want it... but guess what SF/GF doesn't have the enable toggle? 😆

[JimB40]

Ok I thought so. Just confirming.
Do you know @pfeerick why Enable is not implemented for some of functions like Screenshot you mentioned? :)
Overlooked during coding?

[philmoz]

I have checked data variances and it can be hard to fit all of them in one line

I guess that's why it uses two lines to display special/global functions and logical switches.
It would be almost impossible to fit on one line on a portrait orientation screen.

[JimB40]

portrait is easier with data overview as it has a lot vertical space.
I think we have to go with flex - auto increasing line height and moving data elements to the second line if there are more elements) as there are too many options to fix positions.

[ParkerEde]

how would it be to be able to assign individual descriptive names for SF and LS and then display only this in the row?

[mha1]

@philmoz Thanks for all the good work you do!

While working on Special Functions and migrating Logical Switches: could you please have a look at the different column padding between those two. I think it would be nice to have a Special Functions padding with more room for the 1st column like in Logical Switches. So retaining the Logical Switches padding for the migration and adjust Special Functions to the same padding. Possible?

[mha1]

Thanks!

[pfeerick]

Final state of this looks and works great on TX16S and NV14. Thanks for all the discussion and work on this! :)