Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Clean up the UI for the 6POS switch on the radio/simulator #2887

Closed
wants to merge 2 commits into from

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Dec 17, 2022

Change 6POS switch UI:

  • Box for selected position fits between the tick lines
  • Center the position number in the box

Before:
Screen Shot 2022-12-18 at 8 03 41 am

After:
Screen Shot 2022-12-18 at 8 03 08 am

- Box for selected position fits between the tick lines
- Center the position number in the box
@Eldenroot
Copy link
Contributor

Thank you! I like your work and recent PRs! Keep good work!

@gagarinlg
Copy link
Member

I like it

@philmoz
Copy link
Collaborator Author

philmoz commented Dec 18, 2022

I've added the fix for issue #2818 that was suggested in that issue thread.

@pfeerick pfeerick added bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Dec 18, 2022
@pfeerick pfeerick added this to the 2.8.1 milestone Dec 18, 2022
@gagarinlg
Copy link
Member

Did anyone test this with the NV14 simu/simulator?

@mha1
Copy link
Contributor

mha1 commented Dec 18, 2022

Did anyone test this with the NV14 simu/simulator?

I'll set it up

@mha1
Copy link
Contributor

mha1 commented Dec 18, 2022

Did anyone test this with the NV14 simu/simulator?

Well, it seems NV14 doesn't have a 6Pos. And shouldn't have flight mode texts longer than 6 characters. This is not releated to this PR. Want me to put in an issue?

image

@philmoz philmoz closed this Dec 19, 2022
@philmoz
Copy link
Collaborator Author

philmoz commented Dec 19, 2022

Closing in favour of #2893 which is a better solution.

@mha1
Copy link
Contributor

mha1 commented Dec 19, 2022

I take no credit for #2893. Couldn't have done it without input from @eshifri, @gagarinlg and @philmoz. Thank you for the joint effort to solve this what seemed at first very simple problem.

@philmoz philmoz deleted the 6POS-ui branch September 20, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants