Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify telemetry driver (S.Port), fix 2861 #2862

Closed
wants to merge 3 commits into from
Closed

Unify telemetry driver (S.Port), fix 2861 #2862

wants to merge 3 commits into from

Conversation

richardclli
Copy link
Collaborator

Fixes #2861

Summary of changes:
Unify the telemetry driver for all radios.

@richardclli
Copy link
Collaborator Author

There are 2 lines that appear in Tarnis driver but differ from the color radio driver, need to see what change is proper:

In telemetryPortInvertedInit, probeTimeFromStartBit used different values, how to merge this?
probeTimeFromStartBit = 23; //because pin is not probed immediately
// probeTimeFromStartBit = 25; // TODO: Tarnis used 25, how to merge?

In sportSendBuffer, can this line be omitted? This only appears in tarnis driver
// USART_ClearITPendingBit(TELEMETRY_USART, USART_IT_TC); // TODO: This requires? Only appear in tarnis driver

@richardclli
Copy link
Collaborator Author

I already tested this in TX16S and EL18, both works properly with ELRS.

@gagarinlg
Copy link
Member

I think @raphaelcoeffic should do the review. I have never been in that part of the firmware and can not answer your todo-questions.

@richardclli
Copy link
Collaborator Author

I think @raphaelcoeffic should do the review. I have never been in that part of the firmware and can not answer your todo-questions.

@raphaelcoeffic Need your review ^.^

@richardclli
Copy link
Collaborator Author

Closed because it affects the module-api rework:
#3055

@pfeerick pfeerick closed this Feb 2, 2023
@richardclli richardclli deleted the fix-2861 branch October 14, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EL18 cannot achieve 5.25M BAUD for CRSF
3 participants