Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion configure AUX serial port as "External module" #2854

Merged
merged 4 commits into from
Mar 5, 2023

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Dec 12, 2022

Summary of changes:

@elecpower elecpower added enhancement ✨ New feature or request companion Related to the companion software labels Dec 12, 2022
@elecpower elecpower marked this pull request as draft December 12, 2022 20:37
@pfeerick pfeerick added this to the 2.9 milestone Dec 14, 2022
@elecpower
Copy link
Collaborator Author

I am correct to remove the externalaccessmod option all Radio Profile Options?

@elecpower elecpower marked this pull request as ready for review December 14, 2022 09:48
@pfeerick
Copy link
Member

pfeerick commented Dec 14, 2022

I believe so yes - this will be a "standard option" for radios that can support it, runtime configurable via the AUX1 serial choices.

@elecpower
Copy link
Collaborator Author

If that be the case should not the now unnecessary compiler directives be removed from the radio side to avoid confusion?

@rotorman
Copy link
Member

Indeed, good point - thx!

@pfeerick pfeerick self-assigned this Mar 5, 2023
@pfeerick pfeerick force-pushed the elecpower/cpn-access-ext-mod branch from e3b06de to 46c3cfa Compare March 5, 2023 03:26
@pfeerick pfeerick merged commit c84abbf into main Mar 5, 2023
@pfeerick pfeerick deleted the elecpower/cpn-access-ext-mod branch March 5, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants