Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out a dynamic splash screen that fits all screen sizes. #2764

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

richardclli
Copy link
Collaborator

Fixes #638

Summary of changes:

@richardclli richardclli marked this pull request as draft November 19, 2022 02:14
@richardclli
Copy link
Collaborator Author

This is the best I can do, not quite sure how to apply masks.

@richardclli richardclli mentioned this pull request Apr 13, 2023
@richardclli richardclli marked this pull request as ready for review April 14, 2023 07:05
@richardclli
Copy link
Collaborator Author

Let's use this change first, may enhance it later.

@pfeerick pfeerick added the color Related generally to color LCD radios label Apr 14, 2023
@pfeerick pfeerick added this to the 2.9 milestone Apr 14, 2023
@pfeerick
Copy link
Member

Yup, it at least fixes the screen corruption issue for LVGL 8.3.

@pfeerick pfeerick merged commit 01829a1 into main Apr 14, 2023
@pfeerick pfeerick deleted the fix-638 branch April 14, 2023 09:46
@philmoz
Copy link
Collaborator

philmoz commented Apr 16, 2023

This makes having a custom splash screen pretty hard for users.

Maybe the code should check for the presence of a specific file and use it instead so users can still override this new splash screen.

Probably should be something other than 'splash.png' as anyone who is using the default (old) splash screen will still have this on their radio.

@pfeerick
Copy link
Member

I'm not sure what you mean - this only applies when /IMAGES/splash.png is not present as an override for a custom splash screen - which is also normally never present. So nothing changes for users - place /IMAGES/splash.png, enjoy custom splash screen.

This fixes the issue for NV14 where the screen isn't fully filled by the splash screen, which is more of an issue in LVGL8.3. This is also one step towards being able to have a single built-in splash screen for both of the current screen sizes, as well as the one or two more that are coming. The next step will probably be to add the version number (or branch/commit hash if it is a PR or nightly) somewhat like how was shown in #638.

@philmoz
Copy link
Collaborator

philmoz commented Apr 16, 2023

My mistake, you are correct. Sorry.

@pfeerick
Copy link
Member

No problem, thanks for making me double check 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootloader and Startup screen background
3 participants