Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorlcd: Left align input names on Model Inputs tab #1775

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Mar 31, 2022

Summary of changes:

  • left align input names since they can vary in length
  • and no, the TextButton textFlag RIGHTis not a typo... LEFT doesn't work 😆

Before:
image

After:
image

@yds
Copy link
Contributor

yds commented Mar 31, 2022

that looks much better left aligned.. how come I06 looks a little too left when left-aligned? it's the only line without any content on the right..

@pfeerick
Copy link
Member Author

pfeerick commented Mar 31, 2022

Ah god dammit... it's a textbutton rather than a label like all the others.. and didn't want to align left, but pushing it right seemed to work... so need to see what's going on there...

@pfeerick
Copy link
Member Author

pfeerick commented Mar 31, 2022

Ah, ok, the sting is forced centered in the libopenui drawing of the button, and I do not intend to touch anything in libopenui until the LVGL merge happens... so it can either stay this way, let it be centered, or forget about it until after LVGL is in place.

https://github.com/EdgeTX/libopenui/blob/f193395874ef6d371ce4fca9c3c222db88d60816/src/button.cpp#L115-L116

@yds
Copy link
Contributor

yds commented Mar 31, 2022

maybe make it left-aligned for now? with a note to revisit after LVGL is in place? cuz that will look better left-aligned 99% of the time if custom labels are used.. at least my model would look much better..

@pfeerick
Copy link
Member Author

Oh of course, can't have yds's models not looking better... 😆 IMO it's a acceptably tradeoff for now, as I think it's only one or two pixels out... and you still know what's going on... but will leave it a day or to allow comments.

@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Apr 1, 2022
@pfeerick pfeerick added this to the 2.7 milestone Apr 1, 2022
@pfeerick pfeerick merged commit b6dd2fe into main Apr 5, 2022
@pfeerick pfeerick deleted the left-align-input-names branch April 5, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants