Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio freezes when updating internal ELRS via USB-VCP #4740

Closed
1 task done
pfeerick opened this issue Mar 14, 2024 · 3 comments · Fixed by #4822
Closed
1 task done

Radio freezes when updating internal ELRS via USB-VCP #4740

pfeerick opened this issue Mar 14, 2024 · 3 comments · Fixed by #4822
Assignees
@raphaelcoeffic
Labels
bug 🪲 Something isn't working

Comments

@pfeerick
Copy link
Member

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

With the Zorro and T14, updating internal ELRS via USB-VCP locks the radio up hard, requiring removal of the battery. The ELRS pass through update is successful, the radio UI simply stops updating from the moment the update starts. I've not tried this on colorlcd yet to see if this is present there also, implying a common lower level issue.

Expected Behavior

That the radio not require a hard power off when using passthrough updating.

Steps To Reproduce

  1. Connect USB, select USB-VCP
  2. Perform passthrough update using ExpressLRS Configurator
  3. Witness successful update, unresponsive radio

Version

Other (Please specify below)

Transmitter

RadioMaster Zorro

Operating System (OS)

No response

OS Version

No response

Anything else?

v2.10.0-rc1
@pfeerick pfeerick added the bug 🪲 Something isn't working label Mar 14, 2024
@pfeerick pfeerick mentioned this issue Mar 14, 2024
Closed
@philmoz
Copy link
Collaborator

philmoz commented Mar 14, 2024

Possibly related to #4731

@pfeerick
Copy link
Member Author

Yes, sounds very similar.

@raphaelcoeffic raphaelcoeffic self-assigned this Mar 15, 2024
@KondratokGK
Copy link

Same issue, but ELRS is not flashed

@pfeerick pfeerick mentioned this issue Mar 28, 2024
Closed
raphaelcoeffic added a commit that referenced this issue Mar 29, 2024
@raphaelcoeffic
fix(usb): use usbPlugged() to detect disconnect
de2e2f9 
`cdcConnected` is updated from the UI task and cannot be used here.

Fixes #4740
@raphaelcoeffic raphaelcoeffic mentioned this issue Mar 29, 2024
Merged
pfeerick pushed a commit that referenced this issue Mar 30, 2024
@raphaelcoeffic @pfeerick
fix(usb): use usbPlugged() to detect disconnect
64410ef 
`cdcConnected` is updated from the UI task and cannot be used here.

Fixes #4740
3djc pushed a commit that referenced this issue Mar 30, 2024
@raphaelcoeffic
fix(usb): use usbPlugged() to detect disconnect
3d490c4 
`cdcConnected` is updated from the UI task and cannot be used here.

Fixes #4740
ThomasKuehne pushed a commit to ThomasKuehne/edgetx that referenced this issue Apr 5, 2024
@raphaelcoeffic @ThomasKuehne
fix(usb): use usbPlugged() to detect disconnect
81f764d 
`cdcConnected` is updated from the UI task and cannot be used here.

Fixes EdgeTX#4740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaelcoeffic raphaelcoeffic

Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(usb): do not wait for send state EdgeTX/edgetx
4 participants
@raphaelcoeffic @pfeerick @philmoz @KondratokGK