Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost FUTABA SFHSS protocol with ETX 2.8.2 and MPM 1.3.3.20 ? #3434

Closed
1 task done
LS-67 opened this issue Apr 4, 2023 · 27 comments · Fixed by #3444
Closed
1 task done

Lost FUTABA SFHSS protocol with ETX 2.8.2 and MPM 1.3.3.20 ? #3434

LS-67 opened this issue Apr 4, 2023 · 27 comments · Fixed by #3444
Labels
bug 🪲 Something isn't working
Milestone

Comments

@LS-67
Copy link

LS-67 commented Apr 4, 2023

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

The receivers of models under ETX 2.8.1 and FUTABA SFHSS protocol use automatically a "J6" protocol under ETX 2.8.2 and are no longer bindable.
When I create a new model with the FUTABA SFHSS protocol under ETX 2.8.2, this protocol disappears again after switching off/on the TX, to become "J6"

Expected Behavior

keep the SFHSS protocol like in ETX 2.8.1

Steps To Reproduce

  1. install ETX 2.8.2
  2. open a model that was previously in SFHSS
  3. select "Model settings
  4. select "internal RF"

Version

2.8.2

Transmitter

Radiomaster TX16S / TX16SMK2

Anything else?

No response

@LS-67 LS-67 added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Apr 4, 2023
@coaster007
Copy link

similar problem with radiomaster boxer 2.8.2 (External MPM)

Selected protocol Eachine E129.
After off/on Radio the protocol changed to JOYSWAY.
Reverted to 2.8.1 everything works again.

@LS-67 LS-67 changed the title Lost FUTABA SFHSS protocol ? Lost FUTABA SFHSS protocol with ETX 2.8.2 and MPM 1.3.3.20 ? Apr 4, 2023
@mha1
Copy link
Contributor

mha1 commented Apr 4, 2023

You can try this tx16s firmware based on current 2.8.2 built with PR 3435 on top of it. I'd appreciate your feedback if this fixes your problem too.

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

@mha1
Sorry, but this version does not work too : the problem stayed the same !

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

try this please ...

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

it still does not work !

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

What exactly are you doing? You are doing everything on the radio, no Companion, correct?

I tried this but can't reproduce your problem:

  • TX16s, flashed 2.8.2 release, Multi 1.3.3.20
  • power up radio
  • go to select model
  • hit new model, select blank model
  • go to model settings
  • hit internal rf, select Multi, select Futaba (SFHSS comes up as RF Protocol)
  • turn off radio
  • turn on radio
  • failsafe warning pops up, press RTN to continue
  • go to model settings
  • select internal rf
  • Futaba SFHSS is still selected

Please post exact procedure to reproduce

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

I do this only on the TX.

I follow exactly the first 11 steps , but at the 12 step, "J6 Pro" is selected
(I reinstalled MPM 1.3.3.20 but that didn't change anything either!)

The same happen when I choose a model who was SHFSS with ETX 2.8.1 before the change to 2.8.2....

@coaster007
Copy link

@mha1

As mentioned before i have a similar problem with Radiomaster Boxer.
I updated from 2.8.1 to 2.8.2 with existing configured E129 protocol.
After the update the protocol changed to JOYSWAY.

In the multiptotocol file the JOYSWAY position is one after the E129
and the J6 protocol is one position after the SFHSS protocol.

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

This is odd. Where did you get the firmware? self build? language build?

Go to radio setting, version. Please post a screen shot of the internal RF / external RF settings
Go to radio setting, version. Please post a screen shot.

go to model setup, internal RF (does ist say 1.3.3.20?)
hit Mulit and set to Off
turn of radio
turn on radio
go to model setup, internal RF
change from Off to Multi again
does a pop come up saying scanning (or similar)

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

@coaster007 I'm really sorry but I can't reproduce your problem. Just flashed 2.8.1, created a new blank model, selected E129/E129 as MPM internal RF protocol. Then turned off the radio, flashed 2.8.2 and turned it back on. MPM (1.3.3.20) is still on E129/E129.

Are you on language or self-builds?

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

The firmware is tx16s-2.8.2-selfbuild (9c3c6c3)
Date 2023-04-05
Time 11:40:19
OPTS : bluetooth, crossfire,ghost,afhds3,noheli,internalgps,internalmilti,internalaccess,multimodule,luac,cli,passthrough,cli
In the model setup, internal RF, the module status is V1.3.3.20 TAER
When i do this :
"hit Mulit and set to Off
turn of radio
turn on radio
go to model setup, internal RF
change from Off to Multi again
does a pop come up saying scanning (or similar)"

Yes, a pop come up saying "MPM Scanning protocols"

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

I doubt it makes a difference but please use the official release and try the sequence I first posted again.
tx16s-03e80fb-2.8.2-release.zip

@coaster007
Copy link

@mha1 the 2.8.2 version is downloaded from the edgetx homepage (official release).
I haven't see any "MPM scanning ..." screen.
the question is why the 2.8.2 version changed the index in the multiprotocol.txt file to +1 ?

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

Absolutely no change with v2.8.2"FlyingDutchman" :(

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

@coaster007 there was a change for some invaldi protocol (XK). But so far I can't reproduce your problems. I wonder what is different.

@LS-67 have you tried this:

    TX16s, flashed 2.8.2 release, Multi 1.3.3.20
    power up radio
    go to select model
    hit new model, select blank model
    go to model settings
    hit internal rf, select Multi, select Futaba (SFHSS comes up as RF Protocol)
    turn off radio
    turn on radio
    failsafe warning pops up, press RTN to continue
    go to model settings
    select internal rf
    Futaba SFHSS is still selected

please pot your your exact procedure to reproduce

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

I do this "TX16s, flashed 2.8.2 release, Multi 1.3.3.20
power up radio
go to select model
hit new model, select blank model
go to model settings
hit internal rf, select Multi, select Futaba (SFHSS comes up as RF Protocol)
turn off radio
turn on radio
failsafe warning pops up, press RTN to continue
go to model settings
select internal rf
Futaba SFHSS is still selected"

Now, it's OK for a blank model (v2.8.2"FlyingDutchman") (even after turn off/on TX)

But still not OK with a model which was SFHSS before with ETX 2.8.1!

@coaster007
Copy link

o.k. the same test here (radiomaster boxer external MPM) new model with protocol E129 power off/on protocol still E129.
But existing E129 protocol changed to JOYSWAY

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

please post the 2.8.1 model.yml file of the model with Futaba/SFHSS selected

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

How should I do to post it ? Drag and drop doesn't support the file type yml ?

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

zip it?

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

OK. Here it is

FOKONG2.zip

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

Thanks, this looks ok. If you can, please post the yml file showing the wrong protocol in 2.8.2

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

Here it is
NewFOKONG2.zip

@mha1
Copy link
Contributor

mha1 commented Apr 5, 2023

Well, at least it confirms what you are seeing:
moduleData:

before

  0:
    type: TYPE_MULTIMODULE
    subType: 21,0

after

  0:
    type: TYPE_MULTIMODULE
    subType: 22,0

means:
21,Futaba,SFHSS
22,J6PRO

I can reproduce your problem in the simulator. Let me see if I can find the root cause

@LS-67
Copy link
Author

LS-67 commented Apr 5, 2023

Thank's for your help !

@mha1
Copy link
Contributor

mha1 commented Apr 6, 2023

please try this tx16s 2.8.2+ firmware and check if your problem still persists: tx16s-2.8.2+.zip

@LS-67
Copy link
Author

LS-67 commented Apr 6, 2023

It seems to work...perfectly ! Thank you for the time you spent to solve my problem. (vers 2.82-selfbuild 03e80fb)

mha1 added a commit to mha1/edgetx that referenced this issue Apr 6, 2023
@elecpower elecpower removed the triage Bug report awaiting review / sorting label Apr 12, 2023
@richardclli richardclli added this to the 2.8.3 milestone Apr 12, 2023
richardclli pushed a commit to richardclli/edgetx that referenced this issue Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants