Companion - GVs missing from Inputs source list

[pfeerick]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

I noticed when looking at one version of a FM setup I use that GVs are not being shown on the GVs source list for colorlcd. It seems this capability is only valid for colorlcd - B&W don't seem to have this, which is possibly why this is missing. This means if I were to read/write the model the setting would most likely be trashed.

cf. #3086 (comment)

Expected Behavior

That GVs appear in the Inputs source list (between Channels and Telemetry entires), like on the transmitter/simulator.

Steps To Reproduce

1. Configure a Input on TX16S with GV as the source
2. Read that model with Companion
3. See that the Inputs source field is blank in Companion

Version

2.8.0

Transmitter

Radiomaster TX16S / TX16SMK2

Anything else?

Present on both release and main build of firmware/Companion.

Attached is the model file I noticed this on.
Skysurfer-ELRS.zip

[elecpower]

From a quick check GV is not an available Input source for colorlcd in OTX so appears added in ETX.

Questions:

• are there any differences in the mixer engine code between radios types?
• if not, why are GVs not available on B&W edit ui?
• GV is not available as a source in Mixes edit ui for colorlcd, why not if available for Inputs?
• is GV source for a Mix handled in mixer engine code?
• etc

[elecpower]

Using the X9D+ libsim I can confirm that:

• it does load the yml input GV source
• the ui does not let you edit an input source to a GV but does display
• the mixer engine does not discriminate between B&W and color.

Based on these results there needs to be:

• a fix for B&W radio edit ui
• PR fix(cpn): Add gvars to input sources #3097 should be modified to support GV as input source for ALL radios
• the title of this issue should have colorlcd removed
• add B&W to labels