Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion : Error reading hardware stick name with special character #1749

Closed
Batambatam opened this issue Mar 28, 2022 · 1 comment · Fixed by #1754
Closed

Companion : Error reading hardware stick name with special character #1749

Batambatam opened this issue Mar 28, 2022 · 1 comment · Fixed by #1754
Labels
bug 🪲 Something isn't working
Milestone

Comments

@Batambatam
Copy link
Contributor

Describe the bug
At least on Jumper T-Pro :
When setting a name for a stick in Hardware page, Companion can't read the config from radio.yml if there is a special character.
When setting from Companion Hardware tab, YAML file is saved / written without error on the radio.

To Reproduce
In radio : Set "-" as a name for Rud stick in Hardware page.
In companion : read configuration from the radio

Expected behavior
Read configuration without error

Screenshots
Capture d’écran 2022-03-28 à 10 28 33

General information
main branch 2.7.0
YAML generated by Radio

 sticksConfig: 
   0:
      name: -
@Batambatam
Copy link
Contributor Author

The fix would be to write YAML with quoted string (but my knowledge about YAML engine is too limited right now)

 sticksConfig: 
   0:
      name: "-"

@pfeerick pfeerick added this to the 2.7 milestone Mar 28, 2022
@pfeerick pfeerick added the bug 🪲 Something isn't working label Mar 28, 2022
raphaelcoeffic added a commit that referenced this issue Mar 29, 2022
pfeerick pushed a commit that referenced this issue Mar 31, 2022
* Quote stick names

Resolves #1749

* Fix pot, slider and switch names as well.
pfeerick pushed a commit that referenced this issue Apr 1, 2022
* Quote stick names

Resolves #1749

* Fix pot, slider and switch names as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants