Send refactor #67
Merged
Send refactor #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Dec 6, 2024
swansontec
force-pushed
the
william/send-refactor
branch
2 times, most recently
from
fc00c03 to
ccfa76b
Compare
samholmes
approved these changes
Dec 13, 2024
| isPriceChange: false, | ||
| isMarketing: false // Security messages from login server | ||
| }, | ||
| 10 // High priority |
There was a problem hiding this comment.
Your other comment says priority is 0-5. Is 10 too high?
Since the new plan is to stuff these in a queue, we aren't going to get any feedback about whether or not the send worked, at least not at this level.
swansontec
force-pushed
the
william/send-refactor
branch
from
ccfa76b to
463dac2
Compare
This can act as a home for Redis, RabbitMQ, or anything else we need going forward.
swansontec
force-pushed
the
william/send-refactor
branch
from
463dac2 to
d58a0a7
Compare
swansontec
force-pushed
the
william/send-refactor
branch
from
d58a0a7 to
42d8736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none