changed circular reference detection

Eddio0141 · Nov 17, 2023 · 2ef5c93 · 2ef5c93
1 parent f642757
commit 2ef5c93
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/UniTAS/Patcher/Utils/DebugHelp.cs b/UniTAS/Patcher/Utils/DebugHelp.cs
@@ -25,6 +25,12 @@ private static string PrintClass(object obj, ref int indent, List<object> foundR
             return $"{initialIndent}null";
         }
 
+        // circular reference
+        if (foundReferences.Contains(obj))
+        {
+            return $"{initialIndent}...";
+        }
+
         var type = obj.GetType();
         var str = $"{initialIndent}{type.Name} {{\n";
         indent++;
@@ -47,13 +53,6 @@ private static string PrintClass(object obj, ref int indent, List<object> foundR
 
             var value = field.GetValue(obj);
 
-            // circular reference
-            if (foundReferences.Contains(value))
-            {
-                str += "...,\n";
-                continue;
-            }
-
             if (value is null)
             {
                 str += "null,\n";
@@ -62,11 +61,6 @@ private static string PrintClass(object obj, ref int indent, List<object> foundR
 
             var fieldType = field.FieldType;
 
-            if (fieldType.IsClass && fieldType != typeof(string))
-            {
-                foundReferences.Add(value);
-            }
-
             // direct use cases
             if (fieldType.IsPointer)
             {