Skip to content

Commit

Permalink
Merge pull request #1 from edward-simpson/plugin-namespacing
Browse files Browse the repository at this point in the history
Namespacing all events and plugins to prevent interference with others
  • Loading branch information
IvanChepurnyi authored Jul 14, 2021
2 parents 690c9ee + ca97bb8 commit d34b8c2
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions src/etc/frontend/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Magento\CatalogInventory\Observer\AddInventoryDataObserver">
<plugin name="after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
<plugin name="EcomDev_ProductDataPreLoader::after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
</type>

<type name="Magento\Catalog\Model\ProductRepository">
<plugin name="fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
<plugin name="EcomDev_ProductDataPreLoader::fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
</type>

<type name="Magento\Quote\Model\ResourceModel\Quote\Item\Collection">
<plugin name="preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
<plugin name="EcomDev_ProductDataPreLoader::preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
</type>
</config>
6 changes: 3 additions & 3 deletions src/etc/frontend/events.xml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
<event name="catalog_product_collection_load_after">
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
</event>

<event name="sales_quote_item_collection_products_after_load">
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
</event>

<event name="catalog_product_load_after">
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
</event>
</config>
6 changes: 3 additions & 3 deletions src/etc/webapi_rest/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<type name="Magento\CatalogInventory\Observer\AddInventoryDataObserver">
<plugin name="after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
<plugin name="EcomDev_ProductDataPreLoader::after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
</type>

<type name="Magento\Catalog\Model\ProductRepository">
<plugin name="fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
<plugin name="EcomDev_ProductDataPreLoader::fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
</type>

<type name="Magento\Quote\Model\ResourceModel\Quote\Item\Collection">
<plugin name="preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
<plugin name="EcomDev_ProductDataPreLoader::preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
</type>
</config>
6 changes: 3 additions & 3 deletions src/etc/webapi_rest/events.xml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
<event name="catalog_product_collection_load_after">
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
</event>

<event name="core_collection_abstract_load_after">
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
</event>

<event name="catalog_product_load_after">
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
</event>
</config>

0 comments on commit d34b8c2

Please sign in to comment.