Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9 fixes #86

Merged
merged 30 commits into from
Nov 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
78bc696
Update workflows
richardreeve Nov 16, 2023
62dcb26
Missing type in hasheight()
richardreeve Nov 16, 2023
ba89c90
Update project, bump version
richardreeve Nov 16, 2023
2bf97d0
Fix .gitignore
richardreeve Nov 16, 2023
4e543c6
Tidying
richardreeve Nov 16, 2023
771f096
Update code to 1.9 extensions and dependencies
richardreeve Nov 21, 2023
ef867e5
Fix missing exports and add tests
richardreeve Nov 21, 2023
9e5e8ec
Fix matchnodetypes bug, add testing, new exports
richardreeve Nov 22, 2023
58e07bd
Fix conn and conns, export _conn and _conns
richardreeve Nov 22, 2023
142ee86
Fix multi-tree testing
richardreeve Nov 22, 2023
1124194
Add in minimal plot testing
richardreeve Nov 22, 2023
09bd868
Remove returns and testing to check show a bit
richardreeve Nov 22, 2023
a2497d1
Add in haslength()
richardreeve Nov 25, 2023
fa10c83
Fix missing Ref()s in broadcasts and getnodename() signature
richardreeve Nov 25, 2023
04034ac
Fix show() and tests
richardreeve Nov 25, 2023
70528ae
Remove display of pairs as they can't be triggered
richardreeve Nov 25, 2023
612bd8d
Remove unreachable functions
richardreeve Nov 25, 2023
bac4025
Include some new docs
richardreeve Nov 25, 2023
78143d6
Update docs
richardreeve Nov 25, 2023
6cc60e0
Fix getconnections()
richardreeve Nov 25, 2023
f54027e
Update docs and exports
richardreeve Nov 25, 2023
be15c72
Improve doc completeness
richardreeve Nov 25, 2023
292be32
Fix exports
richardreeve Nov 25, 2023
fe7580d
Add module docs
richardreeve Nov 25, 2023
d7477ff
More doc fixes
richardreeve Nov 25, 2023
7f169c8
Fix doc warnings and errors
richardreeve Nov 25, 2023
d5db83f
More doc fixes
richardreeve Nov 25, 2023
c730708
Add parsing docs
richardreeve Nov 25, 2023
159335e
More minor doc and show fixes
richardreeve Nov 25, 2023
c964e54
Update deploydocs()
richardreeve Nov 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/doc-cleanup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout gh-pages branch
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: gh-pages
- name: Delete preview and history + push changes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Set up julia
uses: julia-actions/setup-julia@v1
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Set up julia
uses: julia-actions/setup-julia@v1
with:
version: nightly
arch: x64
- name: Build package
uses: julia-actions/julia-buildpkg@latest
uses: julia-actions/julia-buildpkg@v1
- name: Run tests
uses: julia-actions/julia-runtest@latest
uses: julia-actions/julia-runtest@v1
13 changes: 4 additions & 9 deletions .github/workflows/testing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
fail-fast: false
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Set up julia
uses: julia-actions/setup-julia@v1
with:
Expand All @@ -47,15 +47,10 @@ jobs:
install.packages("ape", repos="http://cran.r-project.org")
shell: R --vanilla --file={0}
- name: Build package
uses: julia-actions/julia-buildpkg@master
uses: julia-actions/julia-buildpkg@v1
- name: Running
uses: julia-actions/julia-runtest@master
uses: julia-actions/julia-runtest@v1
- name: Process coverage
uses: julia-actions/julia-processcoverage@v1
- name: Coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: ./lcov.info
- name: Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
*.jl.mem
/Manifest.toml
test/Manifest.toml
docs/Manifest.toml
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# NEWS

- v0.4.24
- Fix workflows
- v0.4.23
- Fix type warnings
- v0.4.22
Expand Down
44 changes: 34 additions & 10 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
name = "Phylo"
uuid = "aea672f4-3940-5932-aa44-993d1c3ff149"
author = ["Richard Reeve <Richard.Reeve@glasgow.ac.uk>"]
version = "0.4.23"
version = "0.4.24"

[deps]
AxisArrays = "39de3d68-74b9-583c-8d2d-e117c070f3a9"
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
IterableTables = "1c8ee90f-4401-5389-894e-7a04a3dc0f4d"
Graphs = "86223c79-3864-5bf0-83f7-82e725a168b6"
IterableTables = "1c8ee90f-4401-5389-894e-7a04a3dc0f4d"
Missings = "e1d29d7a-bbdc-5cf2-9ac0-f12de2c33e28"
Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Expand All @@ -20,17 +21,40 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
Tokenize = "0796e94c-ce3b-5d07-9a54-7f471281c624"
Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"

[weakdeps]
RCall = "6f49c342-dc21-5d91-9882-a32aef131414"
Requires = "ae029012-a4dd-5104-9daa-d747884805df"

[extensions]
PhyloRCallExt = "RCall"

[compat]
AxisArrays = "0.4"
DataFrames = "^1"
DataFrames = "1"
DataStructures = "0.17, 0.18"
Distances = "0.10"
Distributions = "0.24, 0.25"
IterableTables = "^1"
Graphs = "^1"
Missings = "^1"
RecipesBase = "^1"
Requires = "^1"
Graphs = "1"
IterableTables = "1"
Missings = "1"
Plots = "1"
Printf = "1"
RCall = "0.13"
Random = "1"
RecipesBase = "1"
Requires = "1"
SimpleTraits = "0.9"
Statistics = "1"
Test = "1"
Tokenize = "0.5"
Unitful = "^1"
julia = "^1"
Unitful = "1"
julia = "1"

[extras]
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
RCall = "6f49c342-dc21-5d91-9882-a32aef131414"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["DataFrames", "Plots", "RCall", "Test"]
35 changes: 16 additions & 19 deletions docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,22 @@ using Phylo

makedocs(modules = [Phylo, Phylo.API],
sitename = "Phylo.jl",
pages = [
"Home" => "index.md",
"Tutorial / Quick start" => "tutorial.md",
"Manual" => Any[
"Phylogeny data types" => "man/treetypes.md",
"Creating phylogenies" => "man/input.md",
"Manipulating and building phylogenies" => "man/manipulating.md",
"Traversal and iterators" => "man/traversal.md",
"Getting phylogeny attributes" => "man/attributes.md",
"Modelling traits" => "man/modelling.md",
"Plotting" => "man/plotting.md"
],
"List of functions" => "functionlist.md",
"API" => "api.md"
])
pages = ["Home" => "index.md",
"Tutorial / Quick start" => "tutorial.md",
"Manual" => Any[
"Phylogeny data types" => "man/treetypes.md",
"Creating phylogenies" => "man/input.md",
"Manipulating and building phylogenies" => "man/manipulating.md",
"Traversal and iterators" => "man/traversal.md",
"Getting phylogeny attributes" => "man/attributes.md",
"Modelling traits" => "man/modelling.md",
"Plotting" => "man/plotting.md"
],
"List of functions" => "functionlist.md",
"API" => "api.md"];
format = Documenter.HTML(size_threshold_ignore = ["man/plotting.md",
"man/input.md"]))

deploydocs(repo = "github.com/EcoJulia/Phylo.jl.git",
devbranch = "dev",
deps = Deps.pip("pygments",
"mkdocs",
"mkdocs-material",
"python-markdown-math"))
push_preview = true)
5 changes: 2 additions & 3 deletions docs/src/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ Providing additional code to extend the functionality of the system is simple:

```julia
using Phylo
importall Phylo.API

type SimplestTree <: AbstractTree{Int, Int}
struct SimplestTree <: AbstractTree{Int, Int}
nodes::OrderedDict{Int, BinaryNode{Int}}
branches::Dict{Int, Branch{Int}}
end

import Phylo.API: _addnode!
function _addnode!(tree::SimplestTree, num)
_setnode!(tree, num, BinaryNode{Int}())
return num
Expand All @@ -31,7 +31,6 @@ implementations.

```@autodocs
Modules = [Phylo.API]
Private = false
```

```@index
Expand Down
1 change: 1 addition & 0 deletions docs/src/functionlist.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Function list

```@index
```
75 changes: 41 additions & 34 deletions docs/src/man/attributes.md
Original file line number Diff line number Diff line change
@@ -1,40 +1,72 @@
# Getting tree attributes

### Methods on TreeSets
## Methods on TreeSets

```@docs
ntrees
gettree
gettrees
nroots
getroots
gettreenames
```

### Methods on Trees
## Methods on Trees

```@docs
mrca
nodeheights
getleafnames
getleaves
nleaves
nnodes
ninternal
nbranches
distance
distances
heighttoroot
heightstoroot
getroot
treenametype
gettreename
roottype
nodetype
nodedatatype
nodenametype
branchtype
branchdatatype
branchnametype
getnodenames
getnodename
hasnode
getnode
getnodes
getinternalnodes
getbranchnames
getbranchname
hasbranch
getbranch
getbranches
gettreeinfo
validate!
branchdims
treetype
```

### Methods on Nodes
## Methods on Nodes

```@docs
isleaf
isroot
isinternal
isunattached
degree
indegree
outdegree
hasinbound
getinbound
getoutbounds
getconnections
hasoutboundspace
hasinboundspace
getleafinfo
Expand All @@ -49,46 +81,21 @@ getparent
getancestors
getchildren
getdescendants
getsiblings
```

### Methods on Branches
## Methods on Branches

```@docs
src
dst
conn
conns
haslength
getlength
hasrootheight
getrootheight
setrootheight!
getbranchdata
setbranchdata!
```



```@docs
getroot
treenametype
gettreename
roottype
nodetype
nodedatatype
nodenametype
branchtype
branchdatatype
branchnametype

getnodenames
getnodename
hasnode
getnode
getnodes
getbranchnames
getbranchname
hasbranch
getbranch
getbranches
validate!
branchdims
```


Loading