Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #80

Merged
merged 11 commits into from
Apr 26, 2023
Merged

Bug fixes #80

merged 11 commits into from
Apr 26, 2023

Conversation

richardreeve
Copy link
Member

@richardreeve richardreeve commented Apr 16, 2023

Minor fixes:

  • unrooted trees weren't always creating branches as expected
  • ensure types returned are the same as received
  • node order requests are not obeyed for getnodes() - was for traversal()
  • remove JuliaDB dependency
  • fix R workflow
  • fix Migrate from LightGraphs to Graphs #77

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2023

Pull Request Test Coverage Report for Build 4778535667

  • 18 of 24 (75.0%) changed or added relevant lines in 4 files are covered.
  • 149 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+1.3%) to 58.093%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/rand.jl 0 3 0.0%
src/rcall.jl 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/Branch.jl 1 70.0%
src/trim.jl 1 97.22%
src/Iterators.jl 2 95.05%
src/metrics.jl 3 48.65%
src/TreeSet.jl 4 40.63%
src/routes.jl 5 63.64%
src/Tree.jl 5 81.71%
src/rand.jl 6 61.34%
src/API.jl 8 59.15%
src/Node.jl 8 39.29%
Totals Coverage Status
Change from base Build 1356629049: 1.3%
Covered Lines: 1267
Relevant Lines: 2181

💛 - Coveralls

@richardreeve
Copy link
Member Author

Hi @mkborregaard - no problem if you're busy, I don't think there's anything controversial here - but I just thought I'd ask if you had time to check these fixes that we need before we merge in the inference work.

@richardreeve richardreeve merged commit 8905707 into dev Apr 26, 2023
@richardreeve richardreeve deleted the rr/getnodesfix branch April 26, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from LightGraphs to Graphs
1 participant