Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fork #1

Merged
merged 4 commits into from
Sep 27, 2024
Merged

chore: fork #1

merged 4 commits into from
Sep 27, 2024

Conversation

EchoEllet
Copy link
Owner

@EchoEllet
Copy link
Owner Author

It seems that a exception is thrown as warning in one of the tests, which was before the fork:

00:05 +6: KeyboardDismissOnTap It removes focus when tapped                                                                                                                              

Warning: A call to tap() with finder "Found 1 widget with key [<'box'>]: [
  SizedBox-[<'box'>](width: 100.0, height: 100.0, renderObject: RenderConstrainedBox#9412b relayoutBoundary=up1),
]" derived an Offset (Offset(400.0, 50.0)) that would not hit test on the specified widget.
Maybe the widget is actually off-screen, or another widget is obscuring it, or the widget cannot receive pointer events.
The finder corresponds to this RenderBox: RenderConstrainedBox#9412b relayoutBoundary=up1
The hit test result at that offset is: HitTestResult(_RenderInkFeatures#3649f@Offset(400.0, 50.0), RenderPhysicalModel#2a6f8@Offset(400.0, 50.0), RenderPointerListener#bd145@Offset(400.0, 50.0), RenderSemanticsGestureHandler#ca674@Offset(400.0, 50.0), RenderSemanticsAnnotations#19c62@Offset(400.0, 50.0), RenderRepaintBoundary#25249@Offset(400.0, 50.0), RenderIgnorePointer#bf3ff@Offset(400.0, 50.0), _RenderSnapshotWidget#1e25a@Offset(400.0, 50.0), _RenderSnapshotWidget#95139@Offset(400.0, 50.0), _RenderSnapshotWidget#b118d@Offset(400.0, 50.0), _RenderSnapshotWidget#ff261@Offset(400.0, 50.0), RenderRepaintBoundary#b6aa3@Offset(400.0, 50.0), RenderSemanticsAnnotations#f02ad@Offset(400.0, 50.0), RenderOffstage#5a944@Offset(400.0, 50.0), RenderSemanticsAnnotations#3f025@Offset(400.0, 50.0), _RenderTheater#e2770@Offset(400.0, 50.0), RenderAbsorbPointer#63519@Offset(400.0, 50.0), RenderPointerListener#68ed4@Offset(400.0, 50.0), RenderSemanticsAnnotations#ed5df@Offset(400.0, 50.0), RenderCustomPaint#ba033@Offset(400.0, 50.0), RenderSemanticsAnnotations#65bb4@Offset(400.0, 50.0), RenderSemanticsAnnotations#adaa2@Offset(400.0, 50.0), RenderTapRegionSurface#f0efb@Offset(400.0, 50.0), RenderSemanticsAnnotations#63b8a@Offset(400.0, 50.0), RenderSemanticsAnnotations#51f2d@Offset(400.0, 50.0), RenderSemanticsAnnotations#dadc2@Offset(400.0, 50.0), HitTestEntry<HitTestTarget>#65d04(_ReusableRenderView#1423b), HitTestEntry<HitTestTarget>#fb738(<AutomatedTestWidgetsFlutterBinding>))
#0      WidgetController._getElementPoint (package:flutter_test/src/controller.dart:1941:25)
#1      WidgetController.getCenter (package:flutter_test/src/controller.dart:1792:12)
#2      WidgetController.tap (package:flutter_test/src/controller.dart:1040:18)
#3      main.<anonymous closure>.<anonymous closure> (file:///Users/ellet/Developer/playground/framework_based/flutter/flutter_keyboard_visibility_temp_fork/flutter_keyboard_visibility_temp_fork/test/flutter_keyboard_visibility_test.dart:243:20)
<asynchronous suspension>
#4      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:189:15)
<asynchronous suspension>
#5      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1032:5)
<asynchronous suspension>
#6      StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:114:42)
<asynchronous suspension>
To silence this warning, pass "warnIfMissed: false" to "tap()".
To make this warning fatal, set WidgetController.hitTestWarningShouldBeFatal to true.

00:05 +9: All tests passed!  

@EchoEllet
Copy link
Owner Author

I'm considering about removing the web package from the dependencies since the package doesn't support Flutter web and will always return false.

@EchoEllet EchoEllet marked this pull request as ready for review September 27, 2024 16:32
@EchoEllet EchoEllet merged commit 8eeeb97 into master Sep 27, 2024
@EchoEllet EchoEllet deleted the fork branch September 27, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant