Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fa_ir minor edits (Farsi feedback requested!) #9640

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Fa_ir minor edits (Farsi feedback requested!) #9640

merged 4 commits into from
Oct 2, 2023

Conversation

armanatory
Copy link
Contributor

@armanatory armanatory commented Oct 1, 2023

What does this PR do?

Improve repo

For resources

Description

Minor text upgrade to the Persian translation.

Why is this valuable (or not)?

Makes the text more readable.

How do we know it's really free?

The PR does not contain any new links.

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Add semi-space to the Persian book list
Add semi-space and translation fix to the Persian contribution guide
fix number of blank lines before the heading
@armanatory armanatory changed the title Fa ir minor edits Fa ir minor edits #hacktoberfest-accepted Oct 1, 2023
@armanatory armanatory changed the title Fa ir minor edits #hacktoberfest-accepted Fa_ir minor edits #hacktoberfest-accepted Oct 1, 2023
@armanatory armanatory changed the title Fa_ir minor edits #hacktoberfest-accepted Fa_ir minor edits Oct 1, 2023
@eshellman eshellman added help wanted Needs help solving a blocked / stucked item 🗣️ locale:fa_IR Resources addressing "Persian / Farsi (Iran) / فارسى" language labels Oct 2, 2023
@eshellman eshellman changed the title Fa_ir minor edits Fa_ir minor edits (Farsi feedback requested!) Oct 2, 2023
@neo-apz
Copy link

neo-apz commented Oct 2, 2023

I'm a native speaker and the changes look good to me. 👍

@parsariyahi
Copy link

changes will make translation more readable, looks good 👍

@@ -33,7 +33,7 @@

مواردی از رفتارهای توهین آمیز، آزاردهنده یا غیرقابل قبول می‌توانند با تماس با نگهدارنده پروژه از طریق
victorfelder در gmail.com گزارش شوند.
همه شکایات مورد بررسی و بررسی قرار می گیرند و منجر به پاسخی می شوند
همه شکایات مورد تحقیق و بررسی قرار میگیرند و منجر به پاسخی می شوند

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshellman: Imo, a better translation for this would be:

"تمامی شکایات مورد بررسی و تحقیق قرار خواهند گرفت و به پاسخی"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes will make translation more readable, looks good 👍

@eshellman
Copy link
Collaborator

Thank you team farsi!
Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit e4a0745 into EbookFoundation:main Oct 2, 2023
@armanatory armanatory deleted the fa_ir-minor-edits branch October 2, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Needs help solving a blocked / stucked item 🗣️ locale:fa_IR Resources addressing "Persian / Farsi (Iran) / فارسى" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants