security: GitHub Workflows security hardening #7043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorpa
added
the
👀 Needs Review
davorpa
reviewed
Aug 28, 2022
davorpa
changed the title
davorpa
added
urlchecker
davorpa
added
🚀 ready to merge
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Aug 28, 2022
Seen at PR EbookFoundation#7043 Cherry picked from 50300ca Co-authored-by: Alex <93376818+sashashura@users.noreply.github.com>
|
Thanks, and welcome to free-programming-books! Super to have some extra eyes on things like this. |
2 tasks
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Aug 29, 2022
eshellman
pushed a commit
that referenced
this pull request
Aug 31, 2022
…e_bot report (#7046) * format: expand events * format: add blank lines between steps of check job * format: to run steps using multiline format * feat: group for each output * fix: solve crash on first push (trilom 2 tj action) * chore: upload ab-results as `awesomebot-results.zip` artifact * feat: changed files as workflow output * feat: Generate GitHub Summary using `ab-results-*.json`s * security: limit access rights with `contents: read` Seen at PR #7043 Cherry picked from 50300ca Co-authored-by: Alex <93376818+sashashura@users.noreply.github.com> * chore: setup concurrency policy * chore: modularize using composite actions Co-authored-by: Alex <93376818+sashashura@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.