Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split language agnostic to a separate file #5563

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

eshellman
Copy link
Collaborator

What does this PR do?

It moves the "Language Agnostic" books to a separate file.
Implements #5249

Checklist:

  • [ x] Read our contributing guidelines
  • [ x] Put lists in alphabetical order, correct spacing.
  • [x ] Add needed indications (PDF, access notes, under construction)

Followup

  • Check the output of Travis-CI for linter errors!

@eshellman
Copy link
Collaborator Author

hmmm seems to break the link checker.
we should settle on a crosslink syntax so the obvious cross-links can be made.

@eshellman
Copy link
Collaborator Author

as this will be a massive conflict creator, we should decide whether to procede with it before friday.

@davorpa
Copy link
Member

davorpa commented Sep 28, 2021

hmmm seems to break the link checker.
we should settle on a crosslink syntax so the obvious cross-links can be made.

It's produced by the github action in charge of find what files change and then, scope the links to search with the bot.

This is a known github action issue trilom/file-changes-action#116 when a new branch is created. The first time can't find the parent git ref (commitid: 0000000000000000000000000000000000000000)

- uses: trilom/file-changes-action@v1.2.4
id: file_changes
with:
output: ''

Make another push to branch and it should be resolved 😉

Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All #### headings should be fixed to ### with the propose of mantaining TOC synchronized. 🤗

/labelthis: breaking changes

books/free-programming-books-subjects.md Outdated Show resolved Hide resolved
books/free-programming-books-subjects.md Show resolved Hide resolved
* [Discrete Structures for Computer Science: Counting, Recursion, and Probability](http://cglab.ca/~michiel/DiscreteStructures/) - Michiel Smid


#### Misc
Copy link
Member

@davorpa davorpa Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong heading level

Maybe move entire section to the top, below 0 - Metalists

books/free-programming-books-subjects.md Outdated Show resolved Hide resolved
* [BIOS Disassembly Ninjutsu Uncovered 1st Edition](http://bioshacking.blogspot.co.uk/2012/02/bios-disassembly-ninjutsu-uncovered-1st.html) - Darmawan Salihun (PDF)
* [Hacking the Xbox: An Introduction to Reverse Engineering](https://www.nostarch.com/xboxfree/) - Andrew "bunnie" Huang
* [iOS App Reverse Engineering](https://github.com/iosre/iOSAppReverseEngineering) (PDF)
* [Reverse Engineering for Beginners](http://beginners.re) - Dennis Yurichev (PDF)
Copy link
Member

@davorpa davorpa Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember remove it. See:

I'm working on add those localized versions that are free.

Conflicts ensured

books/free-programming-books-subjects.md Show resolved Hide resolved
books/free-programming-books-subjects.md Show resolved Hide resolved
@davorpa davorpa self-requested a review September 28, 2021 19:25
@davorpa davorpa added the New Feature New feature / enhancement / translation... label Sep 28, 2021
@eshellman eshellman merged commit f279507 into master Sep 29, 2021
@davorpa davorpa mentioned this pull request Oct 2, 2021
@eshellman eshellman deleted the separate-subjects branch October 9, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature / enhancement / translation...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants