-
-
Notifications
You must be signed in to change notification settings - Fork 62.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split language agnostic to a separate file #5563
Conversation
hmmm seems to break the link checker. |
as this will be a massive conflict creator, we should decide whether to procede with it before friday. |
It's produced by the github action in charge of find what files change and then, scope the links to search with the bot. This is a known github action issue trilom/file-changes-action#116 when a new branch is created. The first time can't find the parent git ref ( free-programming-books/.github/workflows/main.yml Lines 8 to 11 in b76cdd7
Make another push to branch and it should be resolved 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All ####
headings should be fixed to ###
with the propose of mantaining TOC synchronized. 🤗
/labelthis: breaking changes
* [Discrete Structures for Computer Science: Counting, Recursion, and Probability](http://cglab.ca/~michiel/DiscreteStructures/) - Michiel Smid | ||
|
||
|
||
#### Misc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong heading level
Maybe move entire section to the top, below 0 - Metalists
❓
* [BIOS Disassembly Ninjutsu Uncovered 1st Edition](http://bioshacking.blogspot.co.uk/2012/02/bios-disassembly-ninjutsu-uncovered-1st.html) - Darmawan Salihun (PDF) | ||
* [Hacking the Xbox: An Introduction to Reverse Engineering](https://www.nostarch.com/xboxfree/) - Andrew "bunnie" Huang | ||
* [iOS App Reverse Engineering](https://github.com/iosre/iOSAppReverseEngineering) (PDF) | ||
* [Reverse Engineering for Beginners](http://beginners.re) - Dennis Yurichev (PDF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember remove it. See:
I'm working on add those localized versions that are free.
Conflicts ensured
What does this PR do?
It moves the "Language Agnostic" books to a separate file.
Implements #5249
Checklist:
Followup