-
-
Notifications
You must be signed in to change notification settings - Fork 62.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update free-programming-books-mm.md #4542
Conversation
Insert Programming Basic by Saturngod.(programming language - Python)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get more guidance on the formatting or conventions in this repository by checking out the contribution guide (CONTRIBUTING.md).
free-programming-books-mm.md
Outdated
@@ -10,6 +10,11 @@ | |||
* [Saturngod's Books](http://books.saturngod.net) | |||
|
|||
|
|||
### Python | |||
|
|||
* [Programming Basic](http://books.saturngod.net/programming_basic/index.html) - Saturngod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of the resource on the page doesn't match the title given in the repository. Could they be synced up? ie "Programming For Beginner"
Also could you remove the index.html
portion of the link as this is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I see, sorry. I visited the page again and see what I read wasn't the books name.
This is indeed my fault, thanks for correcting me.
Could you please still address the redundant index.html at the end of the URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also still could be nice to use the books full name, which is "Programming Basic with Python".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anything still wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL looks good to me! Thank you!
As or the book name, I'm not sure if it's "Programming Basic with Python", or "Programming For Beginner", since the cover page doesn't correlate with the title at the top of the resource. I'd vouch this is good though.
I can also see this is a duplicate of #4515 |
fix the name and make the url short .
I've noticed that the Burmese page had language code 'mm', which doesn't exist, so I corrected it to 'my' , thus causing the merge conflict. So sorry about that! just change the name of your file and it should be all better. |
It's a good resource! |
the author's entire booklist is included under the MetaList heading, thus this Python book is already included in that. Should we still add this separately or close it? |
I'd prefer to have a listing for individual books and omit the meta-listing, so listing this book is a step towards that. |
…n#5196) * fix language code for burmese * Update free-programming-books-my.md
Insert Programming Basic by Saturngod.(programming language - Python)
Hacktoberfest notes:
What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist: