Skip to content

Commit

Permalink
Merge pull request #339 from EasyPost/deprecate_create_list
Browse files Browse the repository at this point in the history
chore: deprecate tracker create_list
  • Loading branch information
Justintime50 authored Jun 14, 2024
2 parents de9a10d + 6f2b359 commit 8150c9d
Show file tree
Hide file tree
Showing 10 changed files with 337 additions and 315 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"require-dev": {
"allejo/php-vcr-sanitizer": "^1.0.9",
"php-coveralls/php-coveralls": "^2.5",
"php-vcr/php-vcr": "^1.6",
"php-vcr/php-vcr": "^1.7",
"phpunit/phpunit": "^9",
"squizlabs/php_codesniffer": "^3.7",
"roave/security-advisories": "dev-latest",
Expand Down
2 changes: 1 addition & 1 deletion examples
Submodule examples updated 2714 files
1 change: 1 addition & 0 deletions lib/EasyPost/Service/TrackerService.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public function create(mixed $params = null): mixed
*
* @param mixed $params
* @return void
* @deprecated
*/
public function createList(mixed $params = null): void
{
Expand Down
4 changes: 2 additions & 2 deletions test/EasyPost/OrderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,13 @@ public function testLowestRate(): void
// Test lowest rate with no filters
$lowestRate = $order->lowestRate();
$this->assertEquals('GroundAdvantage', $lowestRate['service']);
$this->assertEquals('5.93', $lowestRate['rate']);
$this->assertEquals('11.33', $lowestRate['rate']);
$this->assertEquals('USPS', $lowestRate['carrier']);

// Test lowest rate with service filter (this rate is higher than the lowest but should filter)
$lowestRate = $order->lowestRate([], ['Priority']);
$this->assertEquals('Priority', $lowestRate['service']);
$this->assertEquals('6.95', $lowestRate['rate']);
$this->assertEquals('13.79', $lowestRate['rate']);
$this->assertEquals('USPS', $lowestRate['carrier']);

// Test lowest rate with carrier filter (should error due to bad carrier)
Expand Down
128 changes: 66 additions & 62 deletions test/cassettes/orders/buy.yml

Large diffs are not rendered by default.

128 changes: 66 additions & 62 deletions test/cassettes/orders/buyRateObject.yml

Large diffs are not rendered by default.

66 changes: 34 additions & 32 deletions test/cassettes/orders/create.yml

Large diffs are not rendered by default.

126 changes: 65 additions & 61 deletions test/cassettes/orders/getRates.yml

Large diffs are not rendered by default.

69 changes: 36 additions & 33 deletions test/cassettes/orders/lowestRate.yml

Large diffs are not rendered by default.

126 changes: 65 additions & 61 deletions test/cassettes/orders/retrieve.yml

Large diffs are not rendered by default.

0 comments on commit 8150c9d

Please sign in to comment.