Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add SmartRate endpoints functions #225

Merged
merged 8 commits into from
Jul 16, 2024
Merged

[feat] Add SmartRate endpoints functions #225

merged 8 commits into from
Jul 16, 2024

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Jul 12, 2024 •
edited
Loading

Description

  • Add new EstimateDeliveryDateForZipPair, RecommendShipDateForShipment and RecommendShipDateForZipPair
  • Consolidate date parsing utility

Testing

  • Add/update unit tests, re-record cassettes as needed

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc.)

@nwithan8
- Add new EstimateDeliveryDateForShipment, `EstimateDeliveryDateFor…
b0d83f4 
…ZipPair`, `RecommendShipDateForShipment` and `RecommendShipDateForZipPair`

- Existing `GetShipmentEstimatedDeliveryDate` marked as deprecated
- Add/update unit tests, re-record cassettes as needed
@nwithan8 nwithan8 requested a review from a team July 12, 2024 19:43
jchen293
jchen293 previously requested changes Jul 12, 2024
View reviewed changes
smart_rate.go Outdated Show resolved Hide resolved
shipment.go Outdated Show resolved Hide resolved
jchen293
jchen293 reviewed Jul 15, 2024
View reviewed changes
shipment.go Outdated Show resolved Hide resolved
@nwithan8 nwithan8 requested a review from jchen293 July 15, 2024 23:40
jchen293
jchen293 reviewed Jul 16, 2024
View reviewed changes
smart_rate.go Show resolved Hide resolved
smart_rate.go Show resolved Hide resolved
smart_rate.go Outdated Show resolved Hide resolved
smart_rate.go Show resolved Hide resolved
@nwithan8 nwithan8 merged commit c251b4b into master Jul 16, 2024
10 checks passed
@nwithan8 nwithan8 deleted the smartrate_api branch July 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwithan8 @jchen293