Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Card): fix Slat example #1615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

stephenjwatkins
Copy link
Member

@stephenjwatkins stephenjwatkins commented Feb 24, 2025

📝 Changes

  • fix the Card Slat example

the Card > Slat example is one we use quite a bit in the product and it has problems with responding correctly across smaller screen sizes. for example, it wraps awkwardly. this PR fixes it to be more robust, and makes it more complex with the kebab menu that's in a lot of product contexts

note that some css external to Easy UI are required to make this work but that's ok. Easy UI is meant to be composed

Slat example before:

image

Slat example after:

image

✅ Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@stephenjwatkins stephenjwatkins marked this pull request as ready for review February 24, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant