fix(Button): remove support for className #1614
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Changes
className
onButton
<Button className="extend" />
overwrites button styles by accidentally spreading props at the end. this is a pretty big departure from Easy UI's current expectations that presentational components contain their styles and provide extensions only through props, and can cause further breaking changes later with a harder upgrade path🚨 this is technically a breaking change but due to being in pre-release mode, it's better served as a patch. we will need to update 4 instances in our products. these can be found with this
<Button([\s\n\r]+|[^>]+)className
regex 🚨✅ Checklist
Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:
Strikethroughany items that are not applicable to this pull request.