Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): remove support for className #1614

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stephenjwatkins
Copy link
Member

@stephenjwatkins stephenjwatkins commented Feb 24, 2025

📝 Changes

  • remove support for overwriting className on Button

<Button className="extend" /> overwrites button styles by accidentally spreading props at the end. this is a pretty big departure from Easy UI's current expectations that presentational components contain their styles and provide extensions only through props, and can cause further breaking changes later with a harder upgrade path

🚨 this is technically a breaking change but due to being in pre-release mode, it's better served as a patch. we will need to update 4 instances in our products. these can be found with this <Button([\s\n\r]+|[^>]+)className regex 🚨

✅ Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@stephenjwatkins stephenjwatkins marked this pull request as ready for review February 24, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant