Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select,TextField): click through icon #1607

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

stephenjwatkins
Copy link
Member

@stephenjwatkins stephenjwatkins commented Feb 18, 2025

📝 Changes

  • support clicking through icons that overlay Select and TextField

this fixes the bug particularly noticeable on Select components where users can't open the dropdown when their mouse is over the arrow icon. preserves actionable icon such as in password textfield

✅ Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@stephenjwatkins stephenjwatkins marked this pull request as ready for review February 18, 2025 18:30
Copy link
Contributor

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stephenjwatkins stephenjwatkins merged commit 88d2ed3 into main Feb 21, 2025
5 checks passed
@stephenjwatkins stephenjwatkins deleted the fix-select-arrow branch February 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants