Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to why3 1.8 #674

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Upgrade to why3 1.8 #674

merged 1 commit into from
Jan 17, 2025

Conversation

strub
Copy link
Member

@strub strub commented Dec 17, 2024

No description provided.

@strub strub changed the title Update to why3 1.8 Upgrade to why3 1.8 Dec 17, 2024
@strub strub self-assigned this Dec 17, 2024
@strub strub added the chore Ungrateful tasks that need done but that nobody wants to do label Dec 17, 2024
@fdupress
Copy link
Member

It seems this needs us to update the easycrypt-build container, and to wait until the Why3 update has percolated through to nixpkg.

We need a good process for archiving and rolling build containers, trying to balance reproducibility of research artefacts—at least through peer review—and engineering needs.

@strub strub changed the base branch from main to dune-nix January 15, 2025 19:03
@strub
Copy link
Member Author

strub commented Jan 15, 2025

It seems this needs us to update the easycrypt-build container, and to wait until the Why3 update has percolated through to nixpkg.

We need a good process for archiving and rolling build containers, trying to balance reproducibility of research artefacts—at least through peer review—and engineering needs.

All ocaml dependencies come via opam-nix (i.e. do not come from nixpkg). The failure came from a bug in conf-pkg-config that I currently fixed with an overlay

Base automatically changed from dune-nix to main January 15, 2025 19:06
@strub strub enabled auto-merge (rebase) January 15, 2025 19:13
@fdupress
Copy link
Member

Checking—the salsa proof is not failing in any of my own runs, at home or in the local CI.

@strub
Copy link
Member Author

strub commented Jan 17, 2025

Checking—the salsa proof is not failing in any of my own runs, at home or in the local CI.

Even with Why3 1.8?

@fdupress
Copy link
Member

fdupress commented Jan 17, 2025

image

I'll just try to run it with a low SMT timeout and stabilise all edgy SMT calls.

(Oh no! Accidentally leaked that I have Haskell set up...)

@fdupress
Copy link
Member

Fixed. This should also unblock #692 .

@strub
Copy link
Member Author

strub commented Jan 17, 2025

Thank you. Merging.

@strub strub disabled auto-merge January 17, 2025 19:36
@strub strub merged commit d03e63d into main Jan 17, 2025
15 checks passed
@strub strub deleted the why3-1.8 branch January 17, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Ungrateful tasks that need done but that nobody wants to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants