-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft for RFC004 Individual Wallet Unit Attestation #82
Initial draft for RFC004 Individual Wallet Unit Attestation #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review done.
First review is done. |
abe4d49
to
4660a5c
Compare
8c7b277
to
6cae3cd
Compare
@lalc @georgepadayatti @ntsbs One question arose yesterday: Why are we referring now to wallet unit attestation instead of wallet instance attestation? Are these two different things, or are we changing the naming? Actually, the ARF does not mention wallet unit attestation but wallet instance attestation. Shouldn't our vocabulary be aligned? |
In my opinion, we should align to IA even if it's in draft. |
2nd review done. LGTM💯+ but with some questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgepadayatti Please raise the issues discussion as well as add two sections as discussed.
- Wallet Lifecycle
- Validation Section and add a note that it will be fixed in next iteration
- Status Management
I guess we discussed this and i can close this comment. |
I will merge it to main, with outstanding issues to be resolved by #101 @georgepadayatti promised to ensure it's fixed. |
This is the initial draft for RFC004 Individual Wallet Instance Attestations