Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft for RFC004 Individual Wallet Unit Attestation #82

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

ntsbs
Copy link
Collaborator

@ntsbs ntsbs commented Sep 30, 2024

This is the initial draft for RFC004 Individual Wallet Instance Attestations

@andreasabr andreasabr marked this pull request as ready for review October 4, 2024 13:03
Copy link
Collaborator

@andreasabr andreasabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review done.

ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
@georgepadayatti
Copy link
Collaborator

First review is done.

ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Outdated Show resolved Hide resolved
@lalc lalc force-pushed the main branch 7 times, most recently from abe4d49 to 4660a5c Compare October 22, 2024 13:18
@ntsbs ntsbs changed the title Initial draft for RFC004 Individual Wallet Instance Attestations Initial draft for RFC004 Individual Wallet Unit Attestation Oct 24, 2024
@lalc lalc force-pushed the main branch 2 times, most recently from 8c7b277 to 6cae3cd Compare October 25, 2024 02:54
@andreasabr
Copy link
Collaborator

@lalc @georgepadayatti @ntsbs One question arose yesterday: Why are we referring now to wallet unit attestation instead of wallet instance attestation? Are these two different things, or are we changing the naming? Actually, the ARF does not mention wallet unit attestation but wallet instance attestation. Shouldn't our vocabulary be aligned?

@lalc
Copy link
Contributor

lalc commented Oct 25, 2024

@lalc @georgepadayatti @ntsbs One question arose yesterday: Why are we referring now to wallet unit attestation instead of wallet instance attestation? Are these two different things, or are we changing the naming? Actually, the ARF does not mention wallet unit attestation but wallet instance attestation. Shouldn't our vocabulary be aligned?

In my opinion, we should align to IA even if it's in draft.

@georgepadayatti
Copy link
Collaborator

2nd review done. LGTM💯+ but with some questions.

Copy link
Contributor

@lalc lalc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgepadayatti Please raise the issues discussion as well as add two sections as discussed.

  1. Wallet Lifecycle
  2. Validation Section and add a note that it will be fixed in next iteration
  3. Status Management

ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
ewc-rfc004-individual-wallet-attestation.md Show resolved Hide resolved
@lalc
Copy link
Contributor

lalc commented Nov 12, 2024

@lalc @georgepadayatti @ntsbs One question arose yesterday: Why are we referring now to wallet unit attestation instead of wallet instance attestation? Are these two different things, or are we changing the naming? Actually, the ARF does not mention wallet unit attestation but wallet instance attestation. Shouldn't our vocabulary be aligned?

I guess we discussed this and i can close this comment.

@georgepadayatti
Copy link
Collaborator

@lalc @ntsbs I have now moved all the outstanding comments to the below issue, so we can resolve them in the next iteration of RFC 004:

#101

@lalc
Copy link
Contributor

lalc commented Nov 12, 2024

I will merge it to main, with outstanding issues to be resolved by #101

@georgepadayatti promised to ensure it's fixed.

@lalc lalc merged commit ca10b3f into EWC-consortium:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants