Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that "lib" is the CMAKE_INSTALL_LIBDIR in some bazel dependencies #218

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Ensure that "lib" is the CMAKE_INSTALL_LIBDIR in some bazel dependencies #218

merged 5 commits into from
Feb 5, 2025

Conversation

hikinggrass
Copy link
Contributor

If this is not set on some systems this might default to lib64 leading to bazel build errors like "...libcurl.a' was not created

@hikinggrass
Ensure that "lib" is the CMAKE_INSTALL_LIBDIR in some bazel dependencies
14d0d03 
If this is not set on some systems this might default to lib64 leading to bazel build errors like "...libcurl.a' was not created

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Copy link
Contributor Author

An alternative would be to properly support this in the bazel build

@dorezyuk
Copy link
Collaborator

Hi I can’t verify it right now since I’m currently traveling…
But I’m wondering how you build it and why this happens. We compile this for x86 and aarch64 targets and didn’t run into this issue. If it’s urgent feel free to merge otherwise we can have a look together once I’m back:)

@hikinggrass
Copy link
Contributor Author

Hi I can’t verify it right now since I’m currently traveling… But I’m wondering how you build it and why this happens. We compile this for x86 and aarch64 targets and didn’t run into this issue. If it’s urgent feel free to merge otherwise we can have a look together once I’m back:)

Not urgent at all, enjoy your vacation 🌴
I'm building with bazelisk on opensuse tumbleweed, there these artifacts end up in lib64 while bazel seems to expect them in lib

@hikinggrass hikinggrass requested a review from dorezyuk December 12, 2024 12:15
andistorm
andistorm approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve since @dorezyuk approved but hasn't write access

@hikinggrass hikinggrass merged commit 4aa0bf1 into main Feb 5, 2025
5 checks passed
@hikinggrass hikinggrass deleted the bugfix/ensure-cmake-install-libdir-bazel branch February 5, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andistorm andistorm andistorm approved these changes

@dorezyuk dorezyuk dorezyuk approved these changes

Assignees

@dorezyuk dorezyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hikinggrass @dorezyuk @andistorm