Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Page source parameter #68

Closed
wants to merge 2 commits into from

Conversation

elisaifutdinova
Copy link

Could we add some functionality for storing a page source as well, please? 🙏 My proposal is in the PR, that is a very quick solution.

@ghost
Copy link

ghost commented Sep 14, 2021

Dear @elisaifutdinova,

thank you for your proposal and your pull request.

The source code of the html file as received is already stored in the har file requests.har. This file can be opened in the developer toolbar network tab of Firefox/Chrome per drag'n'drop or with tools such as https://stedolan.github.io/jq/manual/ .

If you think that this is not accessible, we could also save it by default – usually, the files are not that big – and not create a command line option for it.

What's your view?

@elisaifutdinova
Copy link
Author

elisaifutdinova commented Sep 14, 2021

Thanks for your comment! Hm 🤔 I've just looked at it, could you please navigate me to the html source code of the page in requests.har?

@elisaifutdinova
Copy link
Author

My view is that there are two ways: WEC should store page source by default or we should describe how to get page source in docs. The first option seems more straightforward. I mean WEC already stores screenshots.

@ghost
Copy link

ghost commented Oct 4, 2021

integrated with 8e19e94. I also mentioned this contribution in the README.md

Thank you for the proposal.

@ghost ghost closed this Oct 4, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant